Bug 142622 - Unreviewed GTK+ gardening on 12th Mar.
Summary: Unreviewed GTK+ gardening on 12th Mar.
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hunseop Jeong
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-12 07:24 PDT by Hunseop Jeong
Modified: 2015-05-19 08:09 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.43 KB, patch)
2015-03-12 07:26 PDT, Hunseop Jeong 		no flags Details | Formatted Diff | Diff
Patch (2.45 KB, patch)
2015-03-13 00:22 PDT, Hunseop Jeong 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hunseop Jeong 2015-03-12 07:24:08 PDT 
Mark attachment-foo test and update the missing tests to existing bugs.
Comment 1 Hunseop Jeong 2015-03-12 07:26:29 PDT 
Created attachment 248515 [details]
Patch
Comment 2 Carlos Garcia Campos 2015-03-12 23:36:29 PDT 
Comment on attachment 248515 [details]
Patch

Shouldn't we use Skip instead of Missing in these cases?
Comment 3 Hunseop Jeong 2015-03-13 00:22:56 PDT 
Created attachment 248575 [details]
Patch
Comment 4 Hunseop Jeong 2015-03-13 00:23:07 PDT 
I changed Missing to Skip.
Comment 5 Carlos Alberto Lopez Perez 2015-03-13 06:38:32 PDT 
Comment on attachment 248575 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248575&action=review

> LayoutTests/platform/gtk/TestExpectations:2376
> +# GTK port doesn't support attachment feature yet.
> +Bug(GTK) fast/attachment/attachment-progress.html [ Skip ]
> +Bug(GTK) fast/attachment/attachment-select-on-click-inside-user-select-all.html [ Skip ]
> +Bug(GTK) fast/attachment/attachment-select-on-click.html [ Skip ]
> +Bug(GTK) fast/attachment/attachment-subtitle.html [ Skip ]
> +Bug(GTK) fast/attachment/attachment-title.html [ Skip ]

I think is beter if you can open a bug number telling that we still dont support the feature and then use that bug number here instead of just using "Bug(GTK)".
Comment 6 Carlos Alberto Lopez Perez 2015-03-13 06:41:14 PDT 
Regarding the usage of Missing vs Skip.

When there is a test that only has an expectation for another port (Mac for example) and there isn't a general expected. There are two options:

1) The test is specific to that port (Mac), so just use "Skip".

2) The test can be used also on our port, but still nobody generated a valid expected for our port, then use "Missing"

In the second case, if you know that the expected generated for the GTK port is valid you can add it. If you have doubts, better open a bug report CC'ing the author of the test, and mark the test as Missing.
Comment 7 Hunseop Jeong 2015-05-19 08:08:11 PDT 
Thanks for your guide, but I closed this bug because it is old one.