Bug 142607 – Web Inspector: Debugger sidebar should group global breakpoints together

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Jonathan Wells]

Global breakpoints such as "All Exceptions" and "All Uncaught Exceptions" should go together in a container at the top of the debugger sidebar.

[Radar WebKit Bug Importer]

<rdar://problem/20131488>

[Jonathan Wells]

Created attachment 248478 [details]
Patch

[Timothy Hatcher]

Comment on attachment 248478 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248478&action=review

> Source/WebInspectorUI/UserInterface/Views/ContainerTreeElement.js:30
> +    WebInspector.FolderizedTreeElement.call(this, WebInspector.ContainerTreeElement.styleFromTypeMap.get(type), title, subtitle, null, hasChildren);

This should be FolderTreeElement not FolderizedTreeElement.

> Source/WebInspectorUI/UserInterface/Views/ContainerTreeElement.js:38
> +WebInspector.ContainerTreeElement.Type = {
> +    Global: "global"
> +};
> +
> +WebInspector.ContainerTreeElement.styleFromTypeMap = new Map();
> +WebInspector.ContainerTreeElement.styleFromTypeMap.set(WebInspector.ContainerTreeElement.Type.Global, "global-container");

You won't need these for FolderTreeElement.

> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:152
> +WebInspector.DebuggerSidebarPanel.GlobalIconStyleClassName = "global-breakpoints-icon";

What icon is this? I don't see a CSS change to add this selector.

[Jonathan Wells]

I decided to just get rid of ContainerTreeElement altogether. I think FolderTreeElement should be able to handle this fine, so I just adjusted it to take different classes. It would still benefit from a different icon maybe? Right now it is a folder. I also went ahead and expanded the folder.

[Jonathan Wells]

Created attachment 248531 [details]
Patch

[Timothy Hatcher]

Comment on attachment 248531 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248531&action=review

> Source/WebInspectorUI/UserInterface/Views/FolderTreeElement.js:28
> +    var classNames = (additionalClassNames && typeof additionalClassNames === "string" ? [additionalClassNames] : []);

Maybe additionalClassNames should be allowed to be an array too?

[Jonathan Wells]

Committed r181452: <http://trac.webkit.org/changeset/181452>

[Joseph Pecoraro]

Comment on attachment 248531 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248531&action=review

> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:107
> +    this._globalBreakpointsFolderTreeElement = new WebInspector.FolderTreeElement(WebInspector.UIString("Global Breakpoints"), null, WebInspector.DebuggerSidebarPanel.GlobalIconStyleClassName);

If this folder is collapsed and a breakpoint inside it is enabled, should there be a UI indicating that?

I think it would be surprising if I paused because of an uncaught exception and couldn't find where to disable it.

(Fortunately if you Pause on a Breakpoint we should that breakpoint in the new pause reason section)