Bug 142595 - Users of Heap::deprecatedReportExtraMemory should switch to reportExtraMemoryAllocated+reportExtraMemoryVisited
Summary: Users of Heap::deprecatedReportExtraMemory should switch to reportExtraMemory...
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks: 142457
  Show dependency tree / graph
 
Reported: 2015-03-11 14:32 PDT by Geoffrey Garen
Modified: 2016-06-01 15:03 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.23 KB, patch)
2015-03-11 17:03 PDT, Geoffrey Garen 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2015-03-11 14:32:26 PDT 
This will reduce GC pressure when GenGC is successful.
Comment 1 Geoffrey Garen 2015-03-11 17:03:17 PDT 
Created attachment 248465 [details]
Patch
Comment 2 Andreas Kling 2015-03-11 17:14:08 PDT 
Comment on attachment 248465 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248465&action=review

r=me

> Source/WebCore/html/HTMLCanvasElement.h:138
> +    size_t memoryCost() const;

memoryCost() and not extraMemoryCost() seems like a mild misnomer, but it's not terribly important.
Comment 3 Geoffrey Garen 2015-03-11 17:15:48 PDT 
Committed r181415: <http://trac.webkit.org/changeset/181415>
Comment 4 Geoffrey Garen 2015-03-11 17:16:15 PDT 
Keeping this open to cover the non-canvas classes.