Bug 142593 - Many users of Heap::reportExtraMemory* are wrong, causing lots of memory growth
Summary: Many users of Heap::reportExtraMemory* are wrong, causing lots of memory growth
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks: 142457
  Show dependency tree / graph
 
Reported: 2015-03-11 14:14 PDT by Geoffrey Garen
Modified: 2015-03-11 15:32 PDT (History)
4 users (show)

See Also:

Attachments
Patch (12.89 KB, patch)
2015-03-11 15:03 PDT, Geoffrey Garen 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2015-03-11 14:14:00 PDT 
These users are wrong:

JSReportExtraMemoryCost
SparseArrayValueMap
JSDocument
JSImageData
JSNodeList
collectionindex
canvas
imageloader
mediaelement
sourcebuffer
xmlhttprequest

They only report cost upon allocation, not upon visit. This can cause lots of memory growth, since it makes the heap thing that eden collection is constantly succeeding in reclaiming huge amounts of memory.
Comment 1 Geoffrey Garen 2015-03-11 15:03:23 PDT 
Created attachment 248455 [details]
Patch
Comment 2 Andreas Kling 2015-03-11 15:25:15 PDT 
Comment on attachment 248455 [details]
Patch

r=me
Comment 3 Geoffrey Garen 2015-03-11 15:32:47 PDT 
Committed r181411: <http://trac.webkit.org/changeset/181411>