Bug 142586 – [Mac] Update fullscreen placeholder UI to use Vibrancy.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

[Mac] Update fullscreen placeholder view to support Vibrancy.

[Jer Noble]

Created attachment 248436 [details]
Patch

[Eric Carlson]

Comment on attachment 248436 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248436&action=review

> Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm:61
> +    _effectView.get().wantsLayer = YES;
> +    _effectView.get().autoresizesSubviews = YES;
> +    _effectView.get().autoresizingMask = NSViewWidthSizable | NSViewHeightSizable;
> +    _effectView.get().blendingMode = NSVisualEffectBlendingModeWithinWindow;
> +    _effectView.get().hidden = YES;
> +    _effectView.get().material = NSVisualEffectMaterialLight;
> +    _effectView.get().state = NSVisualEffectStateActive;

Nit: that is a lot of ".get()."s

> Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm:72
> +    _exitWarning = adoptNS([[NSTextField alloc] initWithFrame:NSZeroRect]);
> +    _exitWarning.get().autoresizingMask = NSViewMinXMargin | NSViewMaxXMargin | NSViewMinYMargin | NSViewMaxYMargin;
> +    _exitWarning.get().bordered = NO;
> +    _exitWarning.get().drawsBackground = NO;
> +    _exitWarning.get().editable = NO;
> +    _exitWarning.get().font = [NSFont systemFontOfSize:27];
> +    _exitWarning.get().selectable = NO;
> +    _exitWarning.get().stringValue = clickToExitFullScreenText();
> +    _exitWarning.get().textColor = [NSColor tertiaryLabelColor];

Ditto.

[Jer Noble]

(In reply to comment #2)
> Comment on attachment 248436 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=248436&action=review
> 
> > Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm:61
> > +    _effectView.get().wantsLayer = YES;
> > +    _effectView.get().autoresizesSubviews = YES;
> > +    _effectView.get().autoresizingMask = NSViewWidthSizable | NSViewHeightSizable;
> > +    _effectView.get().blendingMode = NSVisualEffectBlendingModeWithinWindow;
> > +    _effectView.get().hidden = YES;
> > +    _effectView.get().material = NSVisualEffectMaterialLight;
> > +    _effectView.get().state = NSVisualEffectStateActive;
> 
> Nit: that is a lot of ".get()."s
> 
> > Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm:72
> > +    _exitWarning = adoptNS([[NSTextField alloc] initWithFrame:NSZeroRect]);
> > +    _exitWarning.get().autoresizingMask = NSViewMinXMargin | NSViewMaxXMargin | NSViewMinYMargin | NSViewMaxYMargin;
> > +    _exitWarning.get().bordered = NO;
> > +    _exitWarning.get().drawsBackground = NO;
> > +    _exitWarning.get().editable = NO;
> > +    _exitWarning.get().font = [NSFont systemFontOfSize:27];
> > +    _exitWarning.get().selectable = NO;
> > +    _exitWarning.get().stringValue = clickToExitFullScreenText();
> > +    _exitWarning.get().textColor = [NSColor tertiaryLabelColor];
> 
> Ditto.

The alternative is (e.g.) [_exitWarning setBordered:NO] which is (underneath the hood) an equal number of get()s.

[Jer Noble]

<rdar://problem/20062753>

[WebKit Commit Bot]

Comment on attachment 248436 [details]
Patch

Clearing flags on attachment: 248436

Committed r181403: <http://trac.webkit.org/changeset/181403>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.