Bug 142586 - [Mac] Update fullscreen placeholder UI to use Vibrancy.
Summary: [Mac] Update fullscreen placeholder UI to use Vibrancy.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-03-11 11:21 PDT by Jer Noble
Modified: 2015-03-11 13:28 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.34 KB, patch)
2015-03-11 11:43 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2015-03-11 11:21:51 PDT 
[Mac] Update fullscreen placeholder view to support Vibrancy.
Comment 1 Jer Noble 2015-03-11 11:43:58 PDT 
Created attachment 248436 [details]
Patch
Comment 2 Eric Carlson 2015-03-11 11:47:47 PDT 
Comment on attachment 248436 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248436&action=review

> Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm:61
> +    _effectView.get().wantsLayer = YES;
> +    _effectView.get().autoresizesSubviews = YES;
> +    _effectView.get().autoresizingMask = NSViewWidthSizable | NSViewHeightSizable;
> +    _effectView.get().blendingMode = NSVisualEffectBlendingModeWithinWindow;
> +    _effectView.get().hidden = YES;
> +    _effectView.get().material = NSVisualEffectMaterialLight;
> +    _effectView.get().state = NSVisualEffectStateActive;

Nit: that is a lot of ".get()."s

> Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm:72
> +    _exitWarning = adoptNS([[NSTextField alloc] initWithFrame:NSZeroRect]);
> +    _exitWarning.get().autoresizingMask = NSViewMinXMargin | NSViewMaxXMargin | NSViewMinYMargin | NSViewMaxYMargin;
> +    _exitWarning.get().bordered = NO;
> +    _exitWarning.get().drawsBackground = NO;
> +    _exitWarning.get().editable = NO;
> +    _exitWarning.get().font = [NSFont systemFontOfSize:27];
> +    _exitWarning.get().selectable = NO;
> +    _exitWarning.get().stringValue = clickToExitFullScreenText();
> +    _exitWarning.get().textColor = [NSColor tertiaryLabelColor];

Ditto.
Comment 3 Jer Noble 2015-03-11 11:48:35 PDT 
(In reply to comment #2)
> Comment on attachment 248436 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=248436&action=review
> 
> > Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm:61
> > +    _effectView.get().wantsLayer = YES;
> > +    _effectView.get().autoresizesSubviews = YES;
> > +    _effectView.get().autoresizingMask = NSViewWidthSizable | NSViewHeightSizable;
> > +    _effectView.get().blendingMode = NSVisualEffectBlendingModeWithinWindow;
> > +    _effectView.get().hidden = YES;
> > +    _effectView.get().material = NSVisualEffectMaterialLight;
> > +    _effectView.get().state = NSVisualEffectStateActive;
> 
> Nit: that is a lot of ".get()."s
> 
> > Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm:72
> > +    _exitWarning = adoptNS([[NSTextField alloc] initWithFrame:NSZeroRect]);
> > +    _exitWarning.get().autoresizingMask = NSViewMinXMargin | NSViewMaxXMargin | NSViewMinYMargin | NSViewMaxYMargin;
> > +    _exitWarning.get().bordered = NO;
> > +    _exitWarning.get().drawsBackground = NO;
> > +    _exitWarning.get().editable = NO;
> > +    _exitWarning.get().font = [NSFont systemFontOfSize:27];
> > +    _exitWarning.get().selectable = NO;
> > +    _exitWarning.get().stringValue = clickToExitFullScreenText();
> > +    _exitWarning.get().textColor = [NSColor tertiaryLabelColor];
> 
> Ditto.

The alternative is (e.g.) [_exitWarning setBordered:NO] which is (underneath the hood) an equal number of get()s.
Comment 4 Jer Noble 2015-03-11 12:44:18 PDT 
<rdar://problem/20062753>
Comment 5 WebKit Commit Bot 2015-03-11 13:28:13 PDT 
Comment on attachment 248436 [details]
Patch

Clearing flags on attachment: 248436

Committed r181403: <http://trac.webkit.org/changeset/181403>
Comment 6 WebKit Commit Bot 2015-03-11 13:28:17 PDT 
All reviewed patches have been landed.  Closing bug.