Bug 142576 – [GTK] Add support for handling TLS errors to MiniBrowser

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Carlos Garcia Campos]

It's useful for testing TLS errors handling itself, but also to allow ignoring TLS errors when testing.

[Carlos Garcia Campos]

Created attachment 248412 [details]
Patch

[WebKit Commit Bot]

Attachment 248412 [details] did not pass style-queue:


ERROR: Tools/MiniBrowser/gtk/BrowserWindow.c:374:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/MiniBrowser/gtk/BrowserWindow.c:375:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/MiniBrowser/gtk/BrowserWindow.c:376:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/MiniBrowser/gtk/BrowserWindow.c:377:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 4 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Carlos Garcia Campos]

Created attachment 248413 [details]
Fix coding style issues

[Sergio Villar Senin]

Comment on attachment 248413 [details]
Fix coding style issues

View in context: https://bugs.webkit.org/attachment.cgi?id=248413&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:374
> +        GTK_MESSAGE_QUESTION, GTK_BUTTONS_YES_NO, "%s", "Unacceptable TLS Certificate");

/Unacceptable/Invalid/ ?

[Carlos Alberto Lopez Perez]

BTW.

I think we also need a switch to completely disable certificate validation. Otherwise URLs that embed content from sites with invalid certs don't work.

Example: http://people.igalia.com/clopez/testssl.html

[Carlos Garcia Campos]

Committed r181399: <http://trac.webkit.org/changeset/181399>