Bug 142576 - [GTK] Add support for handling TLS errors to MiniBrowser
Summary: [GTK] Add support for handling TLS errors to MiniBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2015-03-11 04:51 PDT by Carlos Garcia Campos
Modified: 2015-03-11 12:14 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.16 KB, patch)
2015-03-11 04:52 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Fix coding style issues (2.98 KB, patch)
2015-03-11 04:57 PDT, Carlos Garcia Campos 		svillar: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2015-03-11 04:51:32 PDT 
It's useful for testing TLS errors handling itself, but also to allow ignoring TLS errors when testing.
Comment 1 Carlos Garcia Campos 2015-03-11 04:52:53 PDT 
Created attachment 248412 [details]
Patch
Comment 2 WebKit Commit Bot 2015-03-11 04:55:37 PDT 
Attachment 248412 [details] did not pass style-queue:


ERROR: Tools/MiniBrowser/gtk/BrowserWindow.c:374:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/MiniBrowser/gtk/BrowserWindow.c:375:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/MiniBrowser/gtk/BrowserWindow.c:376:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/MiniBrowser/gtk/BrowserWindow.c:377:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 4 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Garcia Campos 2015-03-11 04:57:12 PDT 
Created attachment 248413 [details]
Fix coding style issues
Comment 4 Sergio Villar Senin 2015-03-11 07:44:18 PDT 
Comment on attachment 248413 [details]
Fix coding style issues

View in context: https://bugs.webkit.org/attachment.cgi?id=248413&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:374
> +        GTK_MESSAGE_QUESTION, GTK_BUTTONS_YES_NO, "%s", "Unacceptable TLS Certificate");

/Unacceptable/Invalid/ ?
Comment 5 Carlos Alberto Lopez Perez 2015-03-11 08:58:34 PDT 
BTW.

I think we also need a switch to completely disable certificate validation. Otherwise URLs that embed content from sites with invalid certs don't work.

Example: http://people.igalia.com/clopez/testssl.html
Comment 6 Carlos Garcia Campos 2015-03-11 12:14:56 PDT 
Committed r181399: <http://trac.webkit.org/changeset/181399>