Bug 142574 – UnlinkedFunctionExecutable should store SourceCode instead of offsets

• Status: RESOLVED
• Resolution: WONTFIX
• Component: JavaScriptCore

[Ryosuke Niwa]

UnlinkedFunctionExecutable stores various offsets relative to its owner executable.
Just store SourceCode instead. For one extra pointer, we get a lot more clarity.
If the size is a concern, we can bit-pack two enums better.

[Ryosuke Niwa]

Created attachment 248408 [details]
Cleanup

[Build Bot]

Comment on attachment 248408 [details]
Cleanup

Attachment 248408 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6620840053440512

New failing tests:
fast/profiler/dead-time.html
fast/events/window-onerror-exception-in-attr.html
fast/frames/sandboxed-iframe-forms.html

[Build Bot]

Created attachment 248409 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 248408 [details]
Cleanup

Attachment 248408 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4582258522456064

New failing tests:
fast/profiler/dead-time.html
fast/events/window-onerror-exception-in-attr.html
js/dom/line-column-numbers.html
fast/frames/sandboxed-iframe-forms.html

[Build Bot]

Created attachment 248410 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Ryosuke Niwa]

This won't work because parsing from global code via cache would require us to adjust the source provider as well as line number and columns to be adjusted each time we link.