Bug 142574 - UnlinkedFunctionExecutable should store SourceCode instead of offsets
Summary: UnlinkedFunctionExecutable should store SourceCode instead of offsets
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 142388
  Show dependency treegraph
 
Reported: 2015-03-11 02:23 PDT by Ryosuke Niwa
Modified: 2015-03-13 11:23 PDT (History)
8 users (show)

See Also:


Attachments
Cleanup (13.40 KB, patch)
2015-03-11 02:34 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-mavericks (645.62 KB, application/zip)
2015-03-11 03:31 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (660.80 KB, application/zip)
2015-03-11 03:36 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-03-11 02:23:28 PDT
UnlinkedFunctionExecutable stores various offsets relative to its owner executable.
Just store SourceCode instead. For one extra pointer, we get a lot more clarity.
If the size is a concern, we can bit-pack two enums better.
Comment 1 Ryosuke Niwa 2015-03-11 02:34:29 PDT
Created attachment 248408 [details]
Cleanup
Comment 2 Build Bot 2015-03-11 03:31:01 PDT
Comment on attachment 248408 [details]
Cleanup

Attachment 248408 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6620840053440512

New failing tests:
fast/profiler/dead-time.html
fast/events/window-onerror-exception-in-attr.html
fast/frames/sandboxed-iframe-forms.html
Comment 3 Build Bot 2015-03-11 03:31:05 PDT
Created attachment 248409 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 4 Build Bot 2015-03-11 03:36:38 PDT
Comment on attachment 248408 [details]
Cleanup

Attachment 248408 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4582258522456064

New failing tests:
fast/profiler/dead-time.html
fast/events/window-onerror-exception-in-attr.html
js/dom/line-column-numbers.html
fast/frames/sandboxed-iframe-forms.html
Comment 5 Build Bot 2015-03-11 03:36:41 PDT
Created attachment 248410 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 6 Ryosuke Niwa 2015-03-11 19:12:56 PDT
This won't work because parsing from global code via cache would require us to adjust the source provider as well as line number and columns to be adjusted each time we link.