Bug 142573 - Fix build warning in WebKit2/NetworkProcess module
Summary: Fix build warning in WebKit2/NetworkProcess module
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shivakumar J M
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-10 23:18 PDT by Shivakumar J M
Modified: 2022-03-01 02:47 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.98 KB, patch)
2015-03-10 23:22 PDT, Shivakumar J M
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shivakumar J M 2015-03-10 23:18:11 PDT
Got build warnign in latest build for efl port.

../../Source/WebKit2/NetworkProcess/NetworkProcess.cpp:268:13: warning: unused parameter ‘sessionID’ [-Wunused-parameter]
 static void fetchDiskCacheEntries(SessionID sessionID, std::function<void (Vector<WebsiteData::Entry>)> completionHandler)
             ^
../../Source/WebKit2/NetworkProcess/NetworkProcess.cpp:369:6: warning: unused parameter ‘origins’ [-Wunused-parameter]
 void NetworkProcess::deleteWebsiteDataForOrigins(SessionID sessionID, uint64_t websiteDataTypes, const Vector<SecurityOriginData>& origins, const Vector<String>& cookieHostNames, uint64_t callbackID)
Comment 1 Shivakumar J M 2015-03-10 23:22:58 PDT
Created attachment 248405 [details]
Patch

Fix build warning by removing argument name from function.
Comment 2 WebKit Commit Bot 2015-03-10 23:24:41 PDT
Attachment 248405 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:268:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Darin Adler 2015-03-10 23:54:19 PDT
Comment on attachment 248405 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248405&action=review

> Source/WebKit2/NetworkProcess/NetworkProcess.cpp:369
> +void NetworkProcess::deleteWebsiteDataForOrigins(SessionID sessionID, uint64_t websiteDataTypes, const Vector<SecurityOriginData>& , const Vector<String>& cookieHostNames, uint64_t callbackID)

Should not have left in a space before the comma.
Comment 4 Csaba Osztrogonác 2015-03-11 00:44:19 PDT
After http://trac.webkit.org/changeset/181318 we don't need to fix this
kind of warnings in WebKit2, they are silenced similar to Mac build.
Comment 5 Shivakumar J M 2015-03-11 01:31:29 PDT
(In reply to comment #4)
> After http://trac.webkit.org/changeset/181318 we don't need to fix this
> kind of warnings in WebKit2, they are silenced similar to Mac build.

Ok, will mark these issue as wontfix