Bug 142565 - Add some DateMath test to TestWebKitAPI
Summary: Add some DateMath test to TestWebKitAPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-10 21:39 PDT by Brent Fulgham
Modified: 2015-03-11 10:49 PDT (History)
2 users (show)

See Also:

Attachments
Patch (10.61 KB, patch)
2015-03-10 21:43 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (14.85 KB, patch)
2015-03-11 09:33 PDT, Brent Fulgham 		ap: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2015-03-10 21:39:05 PDT 
The recent Daylight Savings Time bug in Windows showed that we have no DateMath test coverage. Let's fix that!
Comment 1 Brent Fulgham 2015-03-10 21:43:18 PDT 
Created attachment 248396 [details]
Patch
Comment 2 Brent Fulgham 2015-03-11 00:02:56 PDT 
I'll upload a patch with mac, Gtk, and EFL settings tomorrow.
Comment 3 Brent Fulgham 2015-03-11 09:33:23 PDT 
Created attachment 248426 [details]
Patch
Comment 4 Brent Fulgham 2015-03-11 10:01:11 PDT 
Comment on attachment 248426 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248426&action=review

> Tools/TestWebKitAPI/Tests/WTF/DateMath.cpp:189
> +    */

I should get rid of this!
Comment 5 Alexey Proskuryakov 2015-03-11 10:30:02 PDT 
Comment on attachment 248426 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248426&action=review

rs=me

> Tools/TestWebKitAPI/Tests/WTF/DateMath.cpp:122
> +    EXPECT_EQ(1, WTF::dayInMonthFromDayInYear(0, false));

Public WTF symbols are supposed to be used without "WTF", they should always have a using declaration right in the WTF header.
Comment 6 Brent Fulgham 2015-03-11 10:45:42 PDT 
Comment on attachment 248426 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248426&action=review

>> Tools/TestWebKitAPI/Tests/WTF/DateMath.cpp:122
>> +    EXPECT_EQ(1, WTF::dayInMonthFromDayInYear(0, false));
> 
> Public WTF symbols are supposed to be used without "WTF", they should always have a using declaration right in the WTF header.

I'll fix that before landing.
Comment 7 Brent Fulgham 2015-03-11 10:49:31 PDT 
Committed r181393: <http://trac.webkit.org/changeset/181393>