Bug 142564 – Allow adding a button in input elements for auto fill related functionality

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Allow adding a button in input elements for auto fill related functionality

[Sam Weinig]

Created attachment 248395 [details]
Patch

[Sam Weinig]

<rdar://problem/19782066>

[WebKit Commit Bot]

Attachment 248395 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLInputElement.h:435:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
ERROR: Source/WebCore/html/HTMLInputElement.h:436:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 2 in 46 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 248395 [details]
Patch

Attachment 248395 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6315975758577664

New failing tests:
fast/forms/input-auto-fill-button.html

[Build Bot]

Created attachment 248400 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 248395 [details]
Patch

Attachment 248395 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6296498081890304

New failing tests:
fast/forms/input-auto-fill-button.html

[Build Bot]

Created attachment 248401 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Sam Weinig]

Created attachment 248419 [details]
Patch

[WebKit Commit Bot]

Attachment 248419 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLInputElement.h:435:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
ERROR: Source/WebCore/html/HTMLInputElement.h:436:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 2 in 46 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Created attachment 248434 [details]
Patch

[WebKit Commit Bot]

Attachment 248434 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLInputElement.h:435:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
ERROR: Source/WebCore/html/HTMLInputElement.h:436:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 2 in 46 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Created attachment 248435 [details]
Patch

[WebKit Commit Bot]

Attachment 248435 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLInputElement.h:435:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
ERROR: Source/WebCore/html/HTMLInputElement.h:436:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 2 in 47 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 248435 [details]
Patch

Attachment 248435 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5955516333293568

New failing tests:
fast/forms/input-auto-fill-button.html

[Build Bot]

Created attachment 248438 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 248435 [details]
Patch

Attachment 248435 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6679239797506048

New failing tests:
fast/forms/input-auto-fill-button.html

[Build Bot]

Created attachment 248439 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Anders Carlsson]

Comment on attachment 248435 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248435&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:81
> +/* Deprecated - use WKBundleNodeHandleGetHTMLInputElementAutoFilled(WKBundleNodeHandleRef) */
> +WK_EXPORT bool WKBundleNodeHandleGetHTMLInputElementAutofilled(WKBundleNodeHandleRef htmlInputElementHandle);
> +/* Deprecated - use WKBundleNodeHandleSetHTMLInputElementAutoFilled(WKBundleNodeHandleRef, bool) */
> +WK_EXPORT void WKBundleNodeHandleSetHTMLInputElementAutofilled(WKBundleNodeHandleRef htmlInputElementHandle, bool filled);

Do we really need to have these here? Can't we fix the callers and move the definitions to WKDeprecatedFunctions.cpp?

[Sam Weinig]

(In reply to comment #18)
> Comment on attachment 248435 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=248435&action=review
> 
> > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:81
> > +/* Deprecated - use WKBundleNodeHandleGetHTMLInputElementAutoFilled(WKBundleNodeHandleRef) */
> > +WK_EXPORT bool WKBundleNodeHandleGetHTMLInputElementAutofilled(WKBundleNodeHandleRef htmlInputElementHandle);
> > +/* Deprecated - use WKBundleNodeHandleSetHTMLInputElementAutoFilled(WKBundleNodeHandleRef, bool) */
> > +WK_EXPORT void WKBundleNodeHandleSetHTMLInputElementAutofilled(WKBundleNodeHandleRef htmlInputElementHandle, bool filled);
> 
> Do we really need to have these here? Can't we fix the callers and move the
> definitions to WKDeprecatedFunctions.cpp?

I will make that change.

[Sam Weinig]

Committed r181408: <http://trac.webkit.org/changeset/181408>

[Alexey Proskuryakov]

This test fails on Windows, can someone please take care of that? Probably just needs custom results.

https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r184774%20(51999)/fast/forms/input-auto-fill-button-diff.txt