Bug 142560 - Regression(r181257): WTF_WorkQueue.Simple is flaky
Summary: Regression(r181257): WTF_WorkQueue.Simple is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks: 142471
  Show dependency tree / graph
 
Reported: 2015-03-10 19:43 PDT by Chris Dumez
Modified: 2015-03-23 15:57 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.36 KB, patch)
2015-03-23 10:32 PDT, Brent Fulgham 		ap: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-03-10 19:43:08 PDT 
WTF_WorkQueue.Simple is flaky after r181257 I believe:
https://build.webkit.org/builders/Apple%20Mavericks%20Debug%20WK2%20%28Tests%29/builds/10090/steps/run-api-tests/logs/stdio

=================
FAIL WTF_WorkQueue.Simple

/Volumes/Data/slave/mavericks-debug/build/Tools/TestWebKitAPI/Tests/WTF/WorkQueue.cpp:87
Value of: queue->refCount()
  Actual: 2
Expected: 1
=================
Comment 1 Brent Fulgham 2015-03-10 19:53:42 PDT 
Landed an attempt to improve this in r181362 <https://trac.webkit.org/changeset/181362>.
Comment 2 Alexey Proskuryakov 2015-03-22 23:31:12 PDT 
I saw it fail today: 

https://build.webkit.org/builders/Apple%20Win%207%20Debug%20%28Tests%29/builds/65343/steps/run-api-tests/logs/stdio

..\Tests\WTF\WorkQueue.cpp:90
Value of: queue->refCount()
  Actual: 3
Expected: 1
Comment 3 Brent Fulgham 2015-03-23 10:32:20 PDT 
Created attachment 249238 [details]
Patch
Comment 4 Alexey Proskuryakov 2015-03-23 15:08:53 PDT 
Comment on attachment 249238 [details]
Patch

ok
Comment 5 WebKit Commit Bot 2015-03-23 15:12:05 PDT 
Comment on attachment 249238 [details]
Patch

Rejecting attachment 249238 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 249238, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/6241216349863936
Comment 6 Brent Fulgham 2015-03-23 15:57:36 PDT 
Committed r181880: <http://trac.webkit.org/changeset/181880>