Bug 142559 - Inline block children do not have correct baselines if their children are also block elements
Summary: Inline block children do not have correct baselines if their children are als...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-10 19:27 PDT by Myles C. Maxfield
Modified: 2015-03-11 07:41 PDT (History)
9 users (show)

See Also:

Attachments
Patch (5.83 KB, patch)
2015-03-10 19:29 PDT, Myles C. Maxfield 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-03-10 19:27:55 PDT 
Inline block children do not have correct baselines if their children are also block elements
Comment 1 Myles C. Maxfield 2015-03-10 19:29:08 PDT 
Created attachment 248387 [details]
Patch
Comment 2 Darin Adler 2015-03-10 22:53:39 PDT 
Comment on attachment 248387 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248387&action=review

> Source/WebCore/rendering/RenderBlockFlow.cpp:3023
> +            const FontMetrics& fontMetrics = firstLineStyle().fontMetrics();

Maybe auto& here?

> Source/WebCore/rendering/RenderBlockFlow.cpp:3033
> +            const RenderStyle& style = isFirstLine ? firstLineStyle() : this->style();

Maybe auto& here?
Comment 3 Myles C. Maxfield 2015-03-11 07:40:34 PDT 
Comment on attachment 248387 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248387&action=review

>> Source/WebCore/rendering/RenderBlockFlow.cpp:3023
>> +            const FontMetrics& fontMetrics = firstLineStyle().fontMetrics();
> 
> Maybe auto& here?

Done.

>> Source/WebCore/rendering/RenderBlockFlow.cpp:3033
>> +            const RenderStyle& style = isFirstLine ? firstLineStyle() : this->style();
> 
> Maybe auto& here?

Done.
Comment 4 Myles C. Maxfield 2015-03-11 07:41:30 PDT 
Committed r181387: <http://trac.webkit.org/changeset/181387>