Bug 142550 - Functions should have initialization precedence over arguments.
Summary: Functions should have initialization precedence over arguments.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Matthew Mirman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-10 16:19 PDT by Matthew Mirman
Modified: 2015-03-11 16:53 PDT (History)
6 users (show)

See Also:

Attachments
Patch. (2.69 KB, patch)
2015-03-10 16:27 PDT, Matthew Mirman 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Mirman 2015-03-10 16:19:28 PDT 
patch forthcoming. 

rdar://problem/19702564
Comment 1 Matthew Mirman 2015-03-10 16:27:23 PDT 
Created attachment 248369 [details]
Patch.

Ran JSC stress tests on debug without any failures.
Comment 2 Geoffrey Garen 2015-03-10 16:47:20 PDT 
Comment on attachment 248369 [details]
Patch.

r=me
Comment 3 WebKit Commit Bot 2015-03-10 17:33:33 PDT 
Comment on attachment 248369 [details]
Patch.

Clearing flags on attachment: 248369

Committed r181353: <http://trac.webkit.org/changeset/181353>
Comment 4 WebKit Commit Bot 2015-03-10 17:33:37 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2015-03-11 15:43:20 PDT 
Looks like this broke fast/events/event-attribute.html on Windows:

https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fevents%2Fevent-attribute.html

And when I say "broke", I mean "made it pass":

-FAIL /*img*/ typeof (element["ontouchstart"]) should be function. Was undefined.
-FAIL /*img*/ typeof (element["ontouchmove"]) should be function. Was undefined.
-FAIL /*img*/ typeof (element["ontouchend"]) should be function. Was undefined.
-FAIL /*img*/ typeof (element["ontouchcancel"]) should be function. Was undefined.
+PASS /*img*/ typeof (element["ontouchstart"]) is "function"
+PASS /*img*/ typeof (element["ontouchmove"]) is "function"
+PASS /*img*/ typeof (element["ontouchend"]) is "function"
+PASS /*img*/ typeof (element["ontouchcancel"]) is "function"
Comment 6 Matthew Mirman 2015-03-11 16:53:48 PDT 
(In reply to comment #5)
> Looks like this broke fast/events/event-attribute.html on Windows:
> 
> https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=fast%2Fevents%2Fevent-attribute.html
> 
> And when I say "broke", I mean "made it pass":
> 
> -FAIL /*img*/ typeof (element["ontouchstart"]) should be function. Was
> undefined.
> -FAIL /*img*/ typeof (element["ontouchmove"]) should be function. Was
> undefined.
> -FAIL /*img*/ typeof (element["ontouchend"]) should be function. Was
> undefined.
> -FAIL /*img*/ typeof (element["ontouchcancel"]) should be function. Was
> undefined.
> +PASS /*img*/ typeof (element["ontouchstart"]) is "function"
> +PASS /*img*/ typeof (element["ontouchmove"]) is "function"
> +PASS /*img*/ typeof (element["ontouchend"]) is "function"
> +PASS /*img*/ typeof (element["ontouchcancel"]) is "function"

http://trac.webkit.org/changeset/181414