Bug 142509 - Adjustments to media control fonts.
Summary: Adjustments to media control fonts.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-09 15:10 PDT by Roger Fong
Modified: 2015-03-10 12:08 PDT (History)
2 users (show)

See Also:


Attachments
patch (4.63 KB, patch)
2015-03-09 15:12 PDT, Roger Fong
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2015-03-09 15:10:21 PDT
Need to use system font (and thus need to adjust surrounding divs) and also need to sub pixel antialias.

rdar://problem/20085228
Comment 1 Roger Fong 2015-03-09 15:12:30 PDT
Created attachment 248281 [details]
patch
Comment 2 Darin Adler 2015-03-10 10:14:52 PDT
Comment on attachment 248281 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248281&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:261
> +    font: -webkit-small-control;
> +    -webkit-font-smoothing: subpixel-antialiased;

Can we apply these rules more globally to the entire tree? Seems it would be harmless for elements that don’t display any text; we could avoid having to repeat this.
Comment 3 Roger Fong 2015-03-10 12:08:00 PDT
Done.

Committed:
http://trac.webkit.org/changeset/181332