Bug 142496 - Only call showControls if controls are hidden
Summary: Only call showControls if controls are hidden
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-09 10:41 PDT by Roger Fong
Modified: 2015-03-09 13:27 PDT (History)
2 users (show)

See Also:

Attachments
patch (1.73 KB, patch)
2015-03-09 10:46 PDT, Roger Fong 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2015-03-09 10:41:09 PDT 
rdar://problem/20083732

Right now we call showControls unconditionally on mousemove, which is very unnecessary.
Only call if if the controls are hidden.
Comment 1 Roger Fong 2015-03-09 10:46:17 PDT 
Created attachment 248256 [details]
patch
Comment 2 Dean Jackson 2015-03-09 11:47:58 PDT 
Comment on attachment 248256 [details]
patch

All this is a bit dodgy. I'm kind of scared this will break some things :)
Comment 3 Roger Fong 2015-03-09 11:58:56 PDT 
Is it? The controlsAreHidden method wasn't working at all in the first place and the only other place it's used is to update the time displays...
Comment 4 Roger Fong 2015-03-09 13:27:10 PDT 
http://trac.webkit.org/changeset/181279