Bug 142474 - Some event handler fixes
Summary: Some event handler fixes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-08 23:50 PDT by Darin Adler
Modified: 2015-03-10 19:21 PDT (History)
4 users (show)

See Also:

Attachments
Patch (124.17 KB, patch)
2015-03-09 00:04 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-mavericks (531.90 KB, application/zip)
2015-03-09 00:59 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (698.14 KB, application/zip)
2015-03-09 01:06 PDT, Build Bot 		no flags Details
Patch (136.74 KB, patch)
2015-03-09 21:48 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (141.58 KB, patch)
2015-03-10 09:28 PDT, Darin Adler 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2015-03-08 23:50:03 PDT 
Some event handler fixes
Comment 1 Darin Adler 2015-03-09 00:04:49 PDT 
Created attachment 248232 [details]
Patch
Comment 2 Build Bot 2015-03-09 00:59:02 PDT 
Comment on attachment 248232 [details]
Patch

Attachment 248232 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6033706749788160

New failing tests:
fast/events/event-attribute.html
fast/dom/beforeload/video-before-load.html
Comment 3 Build Bot 2015-03-09 00:59:04 PDT 
Created attachment 248233 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 4 Build Bot 2015-03-09 01:06:53 PDT 
Comment on attachment 248232 [details]
Patch

Attachment 248232 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4833904951296000

New failing tests:
fast/events/event-attribute.html
fast/dom/beforeload/video-before-load.html
Comment 5 Build Bot 2015-03-09 01:06:55 PDT 
Created attachment 248234 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 6 Darin Adler 2015-03-09 21:48:38 PDT 
Created attachment 248317 [details]
Patch
Comment 7 Darin Adler 2015-03-10 09:08:33 PDT 
Comment on attachment 248317 [details]
Patch

Conditional mechanism in scripts needs some improvement; that will fix GTK and EFL build failures.
Comment 8 Darin Adler 2015-03-10 09:28:07 PDT 
Created attachment 248331 [details]
Patch
Comment 9 Darin Adler 2015-03-10 10:36:47 PDT 
Looks like this is breaking certain gobject bindings in some subtle way. Guess I’ll need to make an attempt at fixing that.
Comment 10 Darin Adler 2015-03-10 19:21:49 PDT 
Committed r181358: <http://trac.webkit.org/changeset/181358>