Bug 142462 - [iOS Media] Video buffer progress missing on iPhones
Summary: [iOS Media] Video buffer progress missing on iPhones
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-08 14:44 PDT by Dean Jackson
Modified: 2015-03-08 21:55 PDT (History)
1 user (show)

See Also:


Attachments
Patch (12.15 KB, patch)
2015-03-08 14:53 PDT, Dean Jackson
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2015-03-08 14:44:38 PDT
[iOS Media] Video buffer progress missing on iPhones
Comment 1 Dean Jackson 2015-03-08 14:45:02 PDT
rdar://problem/17713396
Comment 2 Dean Jackson 2015-03-08 14:53:36 PDT
Created attachment 248205 [details]
Patch
Comment 3 WebKit Commit Bot 2015-03-08 14:55:26 PDT
Attachment 248205 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterface.h:50:  The parameter name "bufferedTime" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/WebProcess/ios/WebVideoFullscreenManager.h:74:  The parameter name "bufferedTime" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.h:79:  The parameter name "bufferedTime" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 3 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Dean Jackson 2015-03-08 21:55:58 PDT
Committed r181259: <http://trac.webkit.org/changeset/181259>