142455 – [Mac] Refactor media controls code

RESOLVED FIXED 142455

[Mac] Refactor media controls code

https://bugs.webkit.org/show_bug.cgi?id=142455

Summary [Mac] Refactor media controls code

Eric Carlson

Reported 2015-03-08 08:28:12 PDT

Share more code between OS X and iOS media controls.

Attachments
Proposed patch. (24.90 KB, patch) 2015-03-08 16:02 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (803.27 KB, application/zip) 2015-03-08 16:42 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews100 for mac-mavericks (711.23 KB, application/zip) 2015-03-08 17:08 PDT, Build Bot	no flags	Details
Proposed patch (24.87 KB, patch) 2015-03-09 09:56 PDT, Eric Carlson	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (799.74 KB, application/zip) 2015-03-09 10:18 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews100 for mac-mavericks (519.28 KB, application/zip) 2015-03-09 10:41 PDT, Build Bot	no flags	Details
Patch for the bots. (28.72 KB, patch) 2015-03-09 13:44 PDT, Eric Carlson	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-mavericks (520.99 KB, application/zip) 2015-03-09 14:29 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (692.69 KB, application/zip) 2015-03-09 14:36 PDT, Build Bot	no flags	Details
Updated Patch (29.07 KB, patch) 2015-03-10 07:03 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Patch for landing. (28.22 KB, patch) 2015-03-10 13:06 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Eric Carlson

Comment 1 2015-03-08 16:02:50 PDT

Created attachment 248217 [details] Proposed patch.

Build Bot

Comment 2 2015-03-08 16:42:19 PDT

Comment on attachment 248217 [details] Proposed patch. Attachment 248217 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5193173596897280 New failing tests: http/tests/media/hls/video-controls-live-stream.html

Build Bot

Comment 3 2015-03-08 16:42:21 PDT

Created attachment 248219 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Build Bot

Comment 4 2015-03-08 17:07:58 PDT

Comment on attachment 248217 [details] Proposed patch. Attachment 248217 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6530475015274496 New failing tests: http/tests/media/hls/video-controls-live-stream.html

Build Bot

Comment 5 2015-03-08 17:08:01 PDT

Created attachment 248221 [details] Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5

Eric Carlson

Comment 6 2015-03-09 09:56:12 PDT

Created attachment 248249 [details] Proposed patch

Build Bot

Comment 7 2015-03-09 10:18:25 PDT

Comment on attachment 248249 [details] Proposed patch Attachment 248249 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4503798059892736 New failing tests: http/tests/media/hls/video-controls-live-stream.html

Build Bot

Comment 8 2015-03-09 10:18:28 PDT

Created attachment 248252 [details] Archive of layout-test-results from ews107 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Build Bot

Comment 9 2015-03-09 10:41:43 PDT

Comment on attachment 248249 [details] Proposed patch Attachment 248249 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5667736344592384 New failing tests: http/tests/media/hls/video-controls-live-stream.html

Build Bot

Comment 10 2015-03-09 10:41:46 PDT

Created attachment 248255 [details] Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5

Dean Jackson

Comment 11 2015-03-09 11:45:14 PDT

Comment on attachment 248249 [details] Proposed patch This looks good to me.

Eric Carlson

Comment 12 2015-03-09 13:44:22 PDT

Created attachment 248271 [details] Patch for the bots.

Build Bot

Comment 13 2015-03-09 14:29:36 PDT

Comment on attachment 248271 [details] Patch for the bots. Attachment 248271 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6070795403001856 New failing tests: http/tests/media/hls/video-controls-live-stream.html

Build Bot

Comment 14 2015-03-09 14:29:39 PDT

Created attachment 248276 [details] Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 15 2015-03-09 14:36:27 PDT

Comment on attachment 248271 [details] Patch for the bots. Attachment 248271 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5570715180859392 New failing tests: http/tests/media/hls/video-controls-live-stream.html

Build Bot

Comment 16 2015-03-09 14:36:29 PDT

Created attachment 248277 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Eric Carlson

Comment 17 2015-03-10 07:03:00 PDT

Created attachment 248330 [details] Updated Patch

Eric Carlson

Comment 18 2015-03-10 13:06:51 PDT

Created attachment 248349 [details] Patch for landing.

WebKit Commit Bot

Comment 19 2015-03-10 14:27:05 PDT

Comment on attachment 248349 [details] Patch for landing. Clearing flags on attachment: 248349 Committed r181347: <http://trac.webkit.org/changeset/181347>

WebKit Commit Bot

Comment 20 2015-03-10 14:27:11 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware Unspecified

OS Unspecified

Product WebKit

Component Media

Assignee

Eric Carlson

Reported

2015-03-08 08:28 PDT

Modified

2015-03-10 14:27 PDT History

CC List

4 users Show

URL

Keywords

Depends on

Blocks