Bug 142441 - Don't call RenderLayerCompositor::needsToBeComposited() so many times
Summary: Don't call RenderLayerCompositor::needsToBeComposited() so many times
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-07 11:11 PST by Simon Fraser (smfr)
Modified: 2015-03-08 16:39 PDT (History)
5 users (show)

See Also:

Attachments
Patch (15.60 KB, patch)
2015-03-08 11:26 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (15.66 KB, patch)
2015-03-08 11:47 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-03-07 11:11:47 PST 
RenderLayerCompositor::needsToBeComposited() is called from ensureBacking(), but RenderLayerCompositor::computeCompositingRequirements() has already computed this. (Also lots of assertions call it).
Comment 1 Simon Fraser (smfr) 2015-03-08 11:26:39 PDT 
Created attachment 248189 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-03-08 11:47:42 PDT 
Created attachment 248192 [details]
Patch
Comment 3 Brent Fulgham 2015-03-08 12:23:28 PDT 
Comment on attachment 248192 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248192&action=review

R=me

> Source/WebCore/rendering/RenderLayerCompositor.cpp:953
> +

Should we assert that renderer is non-null for debug builds?
Comment 4 Simon Fraser (smfr) 2015-03-08 15:55:26 PDT 
Comment on attachment 248192 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248192&action=review

>> Source/WebCore/rendering/RenderLayerCompositor.cpp:953
>> +
> 
> Should we assert that renderer is non-null for debug builds?

We'll crash right away, so I don't think so.
Comment 5 WebKit Commit Bot 2015-03-08 16:39:44 PDT 
Comment on attachment 248192 [details]
Patch

Clearing flags on attachment: 248192

Committed r181247: <http://trac.webkit.org/changeset/181247>
Comment 6 WebKit Commit Bot 2015-03-08 16:39:48 PDT 
All reviewed patches have been landed.  Closing bug.