Bug 142439 - Improve the event handler test
Summary: Improve the event handler test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-07 09:11 PST by Darin Adler
Modified: 2015-03-07 18:14 PST (History)
4 users (show)

See Also:

Attachments
Patch (226.48 KB, patch)
2015-03-07 09:15 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
diff of old/new files, created by hand (16.16 KB, patch)
2015-03-07 17:02 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2015-03-07 09:11:03 PST 
Improve the event handler test
Comment 1 Darin Adler 2015-03-07 09:15:02 PST 
Created attachment 248155 [details]
Patch
Comment 2 Darin Adler 2015-03-07 16:53:37 PST 
This is a change just to a test. Small change, mostly rename. Review, anyone?
Comment 3 Ryosuke Niwa 2015-03-07 16:58:02 PST 
(In reply to comment #2)
> This is a change just to a test. Small change, mostly rename. Review, anyone?

Could you post the diff for the test?  If you upload it from a subversion checkout (assuming you've used svn mv), it'll actually post the diff for move and the actual diff separately.
Comment 4 Darin Adler 2015-03-07 17:00:32 PST 
I don’t have a subversion checkout. I’m annoyed that git doesn’t do this well. Let me post the diff.
Comment 5 Darin Adler 2015-03-07 17:02:51 PST 
Created attachment 248168 [details]
diff of old/new files, created by hand
Comment 6 Darin Adler 2015-03-07 17:03:10 PST 
OK, posted it now.
Comment 7 WebKit Commit Bot 2015-03-07 18:14:50 PST 
Comment on attachment 248155 [details]
Patch

Clearing flags on attachment: 248155

Committed r181217: <http://trac.webkit.org/changeset/181217>
Comment 8 WebKit Commit Bot 2015-03-07 18:14:55 PST 
All reviewed patches have been landed.  Closing bug.