Bug 142432 - [Win] Revive WTF::WorkQueue on Windows
Summary: [Win] Revive WTF::WorkQueue on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks: 142447 142471
  Show dependency tree / graph
 
Reported: 2015-03-06 21:48 PST by Brent Fulgham
Modified: 2015-03-08 20:24 PDT (History)
6 users (show)

See Also:

Attachments
Patch (22.48 KB, patch)
2015-03-06 22:07 PST, Brent Fulgham 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2015-03-06 21:48:43 PST 
Revive the Windows WorkQueue implementation.
Comment 1 Brent Fulgham 2015-03-06 22:07:05 PST 
Created attachment 248143 [details]
Patch
Comment 2 Anders Carlsson 2015-03-07 13:04:11 PST 
Comment on attachment 248143 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248143&action=review

> Source/WTF/wtf/WorkQueue.h:79
> +    void registerHandle(HANDLE, std::function<void()>);
> +    void unregisterAndCloseHandle(HANDLE);

I think we can get rid of these - they were only used by IPC in WK2.
Comment 3 Brent Fulgham 2015-03-07 20:50:46 PST 
Comment on attachment 248143 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248143&action=review

>> Source/WTF/wtf/WorkQueue.h:79
>> +    void unregisterAndCloseHandle(HANDLE);
> 
> I think we can get rid of these - they were only used by IPC in WK2.

I'll get rid of it. It's easy to retrieve if we need it.
Comment 4 Brent Fulgham 2015-03-07 20:58:18 PST 
Committed r181220: <http://trac.webkit.org/changeset/181220>