Bug 142416 - Support "plus-lighter" in mix-blend mode
Summary: Support "plus-lighter" in mix-blend mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-06 15:49 PST by Dean Jackson
Modified: 2015-05-22 23:15 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.26 MB, patch)
2015-03-06 16:02 PST, Dean Jackson
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2015-03-06 15:49:45 PST
Support "plus-lighter" in mix-blend mode
Comment 1 Dean Jackson 2015-03-06 16:00:54 PST
        <rdar://problem/19993979>
Comment 2 Dean Jackson 2015-03-06 16:02:08 PST
Created attachment 248105 [details]
Patch
Comment 3 Sam Weinig 2015-03-06 16:03:55 PST
r=me
Comment 4 Dean Jackson 2015-03-06 16:09:31 PST
Committed r181191: <http://trac.webkit.org/changeset/181191>
Comment 5 Joseph Pecoraro 2015-05-22 23:12:16 PDT
Comment on attachment 248105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248105&action=review

> Source/WebCore/css/CSSParser.cpp:823
> -            || valueID == CSSValueExclusion || valueID == CSSValuePlusDarker))
> +            || valueID == CSSValueExclusion || valueID == CSSValuePlusDarker || valueID == CSSValuePlusLighter))

I see "plus-darker" and "plus-lighter" are applying to "mix-blend-mode". Should they also apply to "background-blend-mode"? If not, why the distinction?