Bug 142407 - Web Inspector: unify resizer implementations used by DataGrid and Sidebar
Summary: Web Inspector: unify resizer implementations used by DataGrid and Sidebar
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brian Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-03-06 11:51 PST by Brian Burg
Modified: 2015-03-24 13:42 PDT (History)
7 users (show)

See Also:


Attachments
Patch (26.43 KB, patch)
2015-03-06 11:58 PST, Brian Burg
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2015-03-06 11:51:04 PST
.
Comment 1 Radar WebKit Bug Importer 2015-03-06 11:51:22 PST
<rdar://problem/20073999>
Comment 2 Brian Burg 2015-03-06 11:58:33 PST
Created attachment 248084 [details]
Patch
Comment 3 Brian Burg 2015-03-06 12:01:03 PST
This patch doesn't move over the following resizer interactions:

 - Moving undocked inspector window by its fake titlebar
 - Resizing docked inspector (bottom and left dock)
 - Resizing the quick console/split content browser
 - Timeline selection range and center handles

Only the first one should require significant additions to Resizer.js
Comment 4 Brian Burg 2015-03-06 12:06:36 PST
(In reply to comment #3)
> This patch doesn't move over the following resizer interactions:
> 
>  - Moving undocked inspector window by its fake titlebar
>  - Resizing docked inspector (bottom and left dock)
>  - Resizing the quick console/split content browser
>  - Timeline selection range and center handles
> 
> Only the first one should require significant additions to Resizer.js

Oh, there's also a UI-less DragToAdjustController that does some drag related work for sliders in the gradient editor, and drag-to-adjust in the styles editor. The controller seems fine for adjusting numbers up/down, and probably overkill for manipulating dividers/sliders.
Comment 5 Timothy Hatcher 2015-03-06 15:33:46 PST
Comment on attachment 248084 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248084&action=review

Looks good!

> Source/WebInspectorUI/UserInterface/Views/DataGrid.js:115
> +WebInspector.DataGrid.LeftNeighboringColumnIDSymbol = Symbol("left-neighboring-column-id");

Nit: Identifier not ID

> Source/WebInspectorUI/UserInterface/Views/Resizer.js:48
> +    Horizontal: "resizer-rule-orientation-horizontal",
> +    Vertical: "resizer-rule-orientation-vertical",

Symbol!

> Source/WebInspectorUI/UserInterface/Views/Sidebar.js:41
> +    var resizerDelegate = this;

Not sure this line is needed. It is not super helpful, like it would be for booleans.
Comment 6 Brian Burg 2015-03-24 13:42:27 PDT
Committed r181903: <http://trac.webkit.org/changeset/181903>