Bug 142397 - ReadableStreamJSSource should use JSC::Strong UnspecifiedBoolType operator
Summary: ReadableStreamJSSource should use JSC::Strong UnspecifiedBoolType operator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks: 141160
  Show dependency tree / graph
 
Reported: 2015-03-06 08:57 PST by youenn fablet
Modified: 2015-03-09 04:36 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.99 KB, patch)
2015-03-06 09:09 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (2.02 KB, patch)
2015-03-09 03:37 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2015-03-06 08:57:26 PST 
ReadableStreamJSSource uses JSC::Strong to keep JS objects.
It should use UnspecifiedBoolType in lieu of checking for undefined values.
Comment 1 youenn fablet 2015-03-06 09:09:00 PST 
Created attachment 248066 [details]
Patch
Comment 2 Benjamin Poulain 2015-03-08 20:39:12 PDT 
Comment on attachment 248066 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248066&action=review

Oh boy, why didn't anyone review this :(

> Source/WebCore/bindings/js/ReadableStreamJSSource.h:55
> +    virtual bool isErrored() { return m_error; }

!!m_error
Comment 3 youenn fablet 2015-03-09 03:37:52 PDT 
Created attachment 248239 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2015-03-09 04:35:17 PDT 
The commit-queue encountered the following flaky tests while processing attachment 248239 [details]:

media/track/track-insert-after-load-crash.html bug 142484 (author: bfulgham@webkit.org)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2015-03-09 04:36:42 PDT 
Comment on attachment 248239 [details]
Patch for landing

Clearing flags on attachment: 248239

Committed r181264: <http://trac.webkit.org/changeset/181264>
Comment 6 WebKit Commit Bot 2015-03-09 04:36:46 PDT 
All reviewed patches have been landed.  Closing bug.