WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
142397
ReadableStreamJSSource should use JSC::Strong UnspecifiedBoolType operator
https://bugs.webkit.org/show_bug.cgi?id=142397
Summary
ReadableStreamJSSource should use JSC::Strong UnspecifiedBoolType operator
youenn fablet
Reported
2015-03-06 08:57:26 PST
ReadableStreamJSSource uses JSC::Strong to keep JS objects. It should use UnspecifiedBoolType in lieu of checking for undefined values.
Attachments
Patch
(1.99 KB, patch)
2015-03-06 09:09 PST
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Patch for landing
(2.02 KB, patch)
2015-03-09 03:37 PDT
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
youenn fablet
Comment 1
2015-03-06 09:09:00 PST
Created
attachment 248066
[details]
Patch
Benjamin Poulain
Comment 2
2015-03-08 20:39:12 PDT
Comment on
attachment 248066
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=248066&action=review
Oh boy, why didn't anyone review this :(
> Source/WebCore/bindings/js/ReadableStreamJSSource.h:55 > + virtual bool isErrored() { return m_error; }
!!m_error
youenn fablet
Comment 3
2015-03-09 03:37:52 PDT
Created
attachment 248239
[details]
Patch for landing
WebKit Commit Bot
Comment 4
2015-03-09 04:35:17 PDT
The commit-queue encountered the following flaky tests while processing
attachment 248239
[details]
: media/track/track-insert-after-load-crash.html
bug 142484
(author:
bfulgham@webkit.org
) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5
2015-03-09 04:36:42 PDT
Comment on
attachment 248239
[details]
Patch for landing Clearing flags on attachment: 248239 Committed
r181264
: <
http://trac.webkit.org/changeset/181264
>
WebKit Commit Bot
Comment 6
2015-03-09 04:36:46 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug