Bug 142384 - Allow composited clip-path to be updated without a layer repaint
Summary: Allow composited clip-path to be updated without a layer repaint
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-05 22:18 PST by Simon Fraser (smfr)
Modified: 2016-04-27 18:41 PDT (History)
8 users (show)

See Also:

Attachments
Patch (11.47 KB, patch)
2015-03-05 22:25 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-03-05 22:18:00 PST 
Allow composited clip-path to be updated without a layer repaint
Comment 1 Simon Fraser (smfr) 2015-03-05 22:25:45 PST 
Created attachment 248041 [details]
Patch
Comment 2 WebKit Commit Bot 2015-03-06 10:14:35 PST 
Comment on attachment 248041 [details]
Patch

Clearing flags on attachment: 248041

Committed r181164: <http://trac.webkit.org/changeset/181164>
Comment 3 WebKit Commit Bot 2015-03-06 10:14:41 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Elliott Sprehn 2016-04-27 18:41:11 PDT 
Comment on attachment 248041 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248041&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:938
> +    return (clipPath.type() != ClipPathOperation::Shape || clipPath.type() == ClipPathOperation::Shape) && GraphicsLayer::supportsLayerType(GraphicsLayer::Type::Shape);

You have (.type() != ::Shape || .type() == ::Shape) && ...

Did you mean to check for != to something different?