Bug 142377 - [iOS] SVG fonts are garbled
Summary: [iOS] SVG fonts are garbled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-03-05 19:02 PST by Myles C. Maxfield
Modified: 2015-03-06 07:37 PST (History)
6 users (show)

See Also:

Attachments
Patch (6.84 KB, patch)
2015-03-05 19:04 PST, Myles C. Maxfield 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-03-05 19:02:58 PST 
[iOS] SVG fonts are garbled
Comment 1 Myles C. Maxfield 2015-03-05 19:04:45 PST 
Created attachment 248029 [details]
Patch
Comment 2 Myles C. Maxfield 2015-03-05 19:06:53 PST 
<rdar://problem/19616000>
Comment 3 Simon Fraser (smfr) 2015-03-05 19:24:58 PST 
Comment on attachment 248029 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248029&action=review

> Source/WebCore/svg/SVGToOTFFontConversion.cpp:1039
> +    append32(vector, clampTo<int32_t>(number * 0x10000));

This deserves a comment about why you do * 0x10000
Comment 4 Myles C. Maxfield 2015-03-06 07:37:31 PST 
Committed r181155: <http://trac.webkit.org/changeset/181155>