Bug 142371 - REGRESSION (r180782): Data Detector popovers are not dismissed on scroll or zoom
Summary: REGRESSION (r180782): Data Detector popovers are not dismissed on scroll or zoom
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-05 16:40 PST by Beth Dakin
Modified: 2015-03-06 12:16 PST (History)
2 users (show)

See Also:

Attachments
Patch (8.17 KB, patch)
2015-03-05 16:47 PST, Beth Dakin 		no flags Details | Formatted Diff | Diff
Patch with a different approach (4.98 KB, patch)
2015-03-06 11:46 PST, Beth Dakin 		no flags Details | Formatted Diff | Diff
Patch (5.09 KB, patch)
2015-03-06 12:10 PST, Beth Dakin 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2015-03-05 16:40:18 PST 
After http://trac.webkit.org/changeset/180782 DD popovers are not dismissing on scroll.

rdar://problem/20059224
Comment 1 Beth Dakin 2015-03-05 16:47:04 PST 
Created attachment 248019 [details]
Patch
Comment 2 Beth Dakin 2015-03-06 11:46:31 PST 
Created attachment 248082 [details]
Patch with a different approach
Comment 3 Tim Horton 2015-03-06 11:51:24 PST 
Comment on attachment 248082 [details]
Patch with a different approach

View in context: https://bugs.webkit.org/attachment.cgi?id=248082&action=review

> Source/WebKit2/UIProcess/API/mac/WKView.mm:4416
> +    if ([_data->_immediateActionController hasActiveImmediateAction]) {

I wonder if we should do if isKey OR the other thing, because I somewhat fear our ability to keep track of hasActiveImmediateAction
Comment 4 Beth Dakin 2015-03-06 12:10:17 PST 
Created attachment 248086 [details]
Patch
Comment 5 Beth Dakin 2015-03-06 12:16:05 PST 
http://trac.webkit.org/changeset/181176

Thanks Tim!