There are a number of build warnings that need to be resolved. We are going to be switching build warnings to errors soon, which will turn these into build failures: source\javascriptcore\bytecode\codeblock.cpp(622): warning C4701: potentially uninitialized local variable 'sourceCodeRepresentationDescription' used source\javascriptcore\bytecode\codeblock.cpp(622): warning C4703: potentially uninitialized local pointer variable 'sourceCodeRepresentationDescription' used ..\dfg\DFGSpeculativeJIT32_64.cpp(114): warning C4245: 'initializing' : conversion from '' to 'uint32_t', signed/unsigned mismatch ..\dfg\DFGSpeculativeJIT32_64.cpp(118): warning C4245: '=' : conversion from '' to 'uint32_t', signed/unsigned mismatch ..\dfg\DFGSpeculativeJIT32_64.cpp(122): warning C4245: '=' : conversion from '' to 'uint32_t', signed/unsigned mismatch ..\dfg\DFGSpeculativeJIT32_64.cpp(126): warning C4245: '=' : conversion from '' to 'uint32_t', signed/unsigned mismatch ..\runtime\BasicBlockLocation.cpp(57): warning C4245: 'initializing' : conversion from 'int' to 'unsigned int', signed/unsigned mismatch source\javascriptcore\runtime\controlflowprofiler.cpp(117): warning C4701: potentially uninitialized local variable 'bestRange' used ..\..\jsc.cpp(367): warning C4645: function declared with __declspec(noreturn) has a return statement
Created attachment 248320 [details] the patch.
Comment on attachment 248320 [details] the patch. View in context: https://bugs.webkit.org/attachment.cgi?id=248320&action=review > Source/JavaScriptCore/runtime/BasicBlockLocation.cpp:57 > + unsigned minIdx = (unsigned)-1; Maybe UINT_MAX since the previous line uses INT_MAX? Maybe std::numeric_limits<unsigned>::max() if we want to program in C++?
(In reply to comment #2) > Maybe UINT_MAX since the previous line uses INT_MAX? Maybe > std::numeric_limits<unsigned>::max() if we want to program in C++? We have a practice of using (unsigned)-1 all over JSC, but I agree that it's time to move to using std::numeric_limits<unsigned>::max(). Will fix.
Created attachment 248339 [details] patch 2: applied Darin's feedback.
Comment on attachment 248339 [details] patch 2: applied Darin's feedback. r=me
Comment on attachment 248339 [details] patch 2: applied Darin's feedback. Clearing flags on attachment: 248339 Committed r181334: <http://trac.webkit.org/changeset/181334>
All reviewed patches have been landed. Closing bug.