Bug 142361 - Fix the build when NEON_INTRINSICS is enabled
Summary: Fix the build when NEON_INTRINSICS is enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Blocker
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-05 13:14 PST by Sandy
Modified: 2015-03-05 15:56 PST (History)
6 users (show)

See Also:

Attachments
A patch that fixes the bug (2.71 KB, patch)
2015-03-05 13:28 PST, Sandy 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sandy 2015-03-05 13:14:14 PST 
Project does not compile when ARM_NEON_INTRINSICS is enabled. In file 'WebKit/Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp' variable 'isAlphaImage' is used as a function (i.e., isAlphaImage()) and in file 'WebKit/Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNEON.h' a ';' is missing.
Comment 1 Sandy 2015-03-05 13:28:16 PST 
Created attachment 247990 [details]
A patch that fixes the bug
Comment 2 Csaba Osztrogonác 2015-03-05 15:09:55 PST 
Just to note: r177000 caused the isAlphaImage issue and r170433 caused 
the return issue. Thanks for the fix. But it means that we didn't enable
NEON on our ARM bots, but we should.
Comment 3 WebKit Commit Bot 2015-03-05 15:56:50 PST 
Comment on attachment 247990 [details]
A patch that fixes the bug

Clearing flags on attachment: 247990

Committed r181110: <http://trac.webkit.org/changeset/181110>
Comment 4 WebKit Commit Bot 2015-03-05 15:56:55 PST 
All reviewed patches have been landed.  Closing bug.