Bug 142344 - Simple line layout: Merge TextFragmentIterator::findNextBreakablePosition() and TextFragmentIterator::findNextNonWhitespacePosition().
Summary: Simple line layout: Merge TextFragmentIterator::findNextBreakablePosition() a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on: 142508
Blocks:
  Show dependency treegraph
 
Reported: 2015-03-05 08:23 PST by zalan
Modified: 2015-03-10 08:16 PDT (History)
6 users (show)

See Also:


Attachments
Patch (9.77 KB, patch)
2015-03-05 09:31 PST, zalan
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-mavericks (495.98 KB, application/zip)
2015-03-05 10:05 PST, Build Bot
no flags Details
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (298.28 KB, application/zip)
2015-03-05 10:20 PST, Build Bot
no flags Details
Patch (9.84 KB, patch)
2015-03-05 12:55 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (9.84 KB, patch)
2015-03-09 09:11 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (9.96 KB, patch)
2015-03-09 18:19 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2015-03-05 08:23:51 PST
To share the same logic.
Comment 1 zalan 2015-03-05 09:31:56 PST
Created attachment 247958 [details]
Patch
Comment 2 Build Bot 2015-03-05 10:05:16 PST
Comment on attachment 247958 [details]
Patch

Attachment 247958 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5367984134553600

Number of test failures exceeded the failure limit.
Comment 3 Build Bot 2015-03-05 10:05:19 PST
Created attachment 247961 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 4 Build Bot 2015-03-05 10:20:09 PST
Comment on attachment 247958 [details]
Patch

Attachment 247958 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4814558271111168

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2015-03-05 10:20:11 PST
Created attachment 247965 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 6 zalan 2015-03-05 12:55:38 PST
Created attachment 247985 [details]
Patch
Comment 7 zalan 2015-03-09 09:11:11 PDT
Created attachment 248246 [details]
Patch
Comment 8 Antti Koivisto 2015-03-09 09:22:58 PDT
Comment on attachment 248246 [details]
Patch

r=me
Comment 9 WebKit Commit Bot 2015-03-09 10:10:21 PDT
Comment on attachment 248246 [details]
Patch

Clearing flags on attachment: 248246

Committed r181268: <http://trac.webkit.org/changeset/181268>
Comment 10 WebKit Commit Bot 2015-03-09 10:10:27 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Alexey Proskuryakov 2015-03-09 14:52:22 PDT
Did this cause bug 142507?
Comment 12 WebKit Commit Bot 2015-03-09 15:02:46 PDT
Re-opened since this is blocked by bug 142508
Comment 13 Alexey Proskuryakov 2015-03-09 15:06:25 PDT
Yes - ASan detects a mistake on so many tests that it's become useless for everything else. Will roll out.
Comment 14 zalan 2015-03-09 18:19:53 PDT
Created attachment 248305 [details]
Patch
Comment 15 WebKit Commit Bot 2015-03-10 08:16:54 PDT
Comment on attachment 248305 [details]
Patch

Clearing flags on attachment: 248305

Committed r181325: <http://trac.webkit.org/changeset/181325>
Comment 16 WebKit Commit Bot 2015-03-10 08:16:59 PDT
All reviewed patches have been landed.  Closing bug.