RESOLVED FIXED 142339
Move disk cache classes to namespace 
https://bugs.webkit.org/show_bug.cgi?id=142339
Summary Move disk cache classes to namespace
Antti Koivisto
Reported 2015-03-05 06:36:44 PST
Move it to NetworkCache namespace.
Attachments
patch (90.86 KB, patch)
2015-03-05 06:40 PST, Antti Koivisto 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2015-03-05 06:40:31 PST
Created attachment 247949 [details] patch
WebKit Commit Bot
Comment 2 2015-03-05 06:42:51 PST
Attachment 247949 [details] did not pass style-queue: ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:96: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:97: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:98: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:99: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:100: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:101: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:102: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:103: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:104: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:105: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:78: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:97: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:247: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:328: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:376: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm:429: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannel.h:44: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannel.h:45: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 19 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Antti Koivisto
Comment 3 2015-03-06 00:37:07 PST
https://trac.webkit.org/r181140
David Kilzer (:ddkilzer)
Comment 4 2015-03-06 01:42:11 PST
(In reply to comment #3) > https://trac.webkit.org/r181140 Attempted a build fix for Yosemite open source buildbots (even though the ChangeLog says Mavericks, because I have trouble mapping nature pictures to names): Committed r181147: <https://trac.webkit.org/changeset/181147>
Note You need to log in before you can comment on or make changes to this bug.