Bug 142329 – [CSS Grid Layout] Using automatic (instead of min-content) minimums for 'auto' tracks

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Sergio Villar Senin]

This has recently changed in the specs. See https://lists.w3.org/Archives/Public/www-style/2015Jan/0166.html for more details.

The most important part is the following:

    More precisely (syntax-wise), this would allow 'auto' to be used within the
    minmax() function (it's currently forbidden) and have the 'auto' keyword map
    to minmax(auto, auto) instead of minmax(min-content, max-content).
        * As a minimum, 'auto' would mean "use the specified minimum size, or if
          that is auto, treat as 0 or min-content per Flexbox rules".
        * As a maximum, 'auto' would mean "use the max-content size".

[Sergio Villar Senin]

This involves merging the following two patches from Blink:

* [CSSGridLayout] Use automatic minimums for 'auto' tracks r198697
* [CSS Grid Layout] The 'auto' value is valid for maxTrackBreadth property r200478

[Sergio Villar Senin]

Created attachment 261181 [details]
Patch

[Darin Adler]

Comment on attachment 261181 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261181&action=review

> Source/WebCore/rendering/RenderGrid.cpp:559
> +        return LayoutUnit();

In new code we often use { } instead of LayoutUnit(); a bit more terse, not 100% sure it’s better.

[Sergio Villar Senin]

Committed r189911: <http://trac.webkit.org/changeset/189911>