Bug 142323 - Web Inspector: Add ObjectTreeBaseTreeElement to share functionality
Summary: Web Inspector: Add ObjectTreeBaseTreeElement to share functionality
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-03-04 21:02 PST by Joseph Pecoraro
Modified: 2015-03-05 11:40 PST (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (48.13 KB, patch)
2015-03-04 21:25 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-03-04 21:02:26 PST 
* SUMMARY
Add ObjectTreeBaseTreeElement to share functionality between different ObjectTree*TreeElement types.

  - Used by all:
    - property path support, UIStrings for failure
    - contextmenu support, Log Value / Copy Path to Property
    - "resolved value"

  - Used by Property and ArrayIndex:
    - handle invoking getters and thus getterValue || property.value
Comment 1 Radar WebKit Bug Importer 2015-03-04 21:02:52 PST 
<rdar://problem/20050723>
Comment 2 Joseph Pecoraro 2015-03-04 21:06:42 PST 
More shared code for:

  - general tree element construction
  - creation of readonly icons
  - function property string handling
Comment 3 Joseph Pecoraro 2015-03-04 21:25:06 PST 
Created attachment 247928 [details]
[PATCH] Proposed Fix

Hard patch to follow...
Comment 4 Timothy Hatcher 2015-03-04 21:33:05 PST 
Comment on attachment 247928 [details]
[PATCH] Proposed Fix

Very nice!
Comment 5 WebKit Commit Bot 2015-03-05 11:40:32 PST 
Comment on attachment 247928 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 247928

Committed r181089: <http://trac.webkit.org/changeset/181089>
Comment 6 WebKit Commit Bot 2015-03-05 11:40:36 PST 
All reviewed patches have been landed.  Closing bug.