RESOLVED FIXED 142323
Web Inspector: Add ObjectTreeBaseTreeElement to share functionality 
https://bugs.webkit.org/show_bug.cgi?id=142323
Summary Web Inspector: Add ObjectTreeBaseTreeElement to share functionality
Joseph Pecoraro
Reported 2015-03-04 21:02:26 PST
* SUMMARY Add ObjectTreeBaseTreeElement to share functionality between different ObjectTree*TreeElement types. - Used by all: - property path support, UIStrings for failure - contextmenu support, Log Value / Copy Path to Property - "resolved value" - Used by Property and ArrayIndex: - handle invoking getters and thus getterValue || property.value
Attachments
[PATCH] Proposed Fix (48.13 KB, patch)
2015-03-04 21:25 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-03-04 21:02:52 PST
<rdar://problem/20050723>
Joseph Pecoraro
Comment 2 2015-03-04 21:06:42 PST
More shared code for: - general tree element construction - creation of readonly icons - function property string handling
Joseph Pecoraro
Comment 3 2015-03-04 21:25:06 PST
Created attachment 247928 [details] [PATCH] Proposed Fix Hard patch to follow...
Timothy Hatcher
Comment 4 2015-03-04 21:33:05 PST
Comment on attachment 247928 [details] [PATCH] Proposed Fix Very nice!
WebKit Commit Bot
Comment 5 2015-03-05 11:40:32 PST
Comment on attachment 247928 [details] [PATCH] Proposed Fix Clearing flags on attachment: 247928 Committed r181089: <http://trac.webkit.org/changeset/181089>
WebKit Commit Bot
Comment 6 2015-03-05 11:40:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.