Bug 142305 – Update inline media control icons for OSX

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Roger Fong]

Update inline media control icons for OSX
This change will include the play button, volume button, fullscreen button, and caption button.

[Roger Fong]

rdar://problem/19997484

[Roger Fong]

Created attachment 247901 [details]
patch

[Dean Jackson]

Comment on attachment 247901 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247901&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:134
> +    background-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 12 15" fill="white"><path d="M 0,1 v 13 h 4 v -13 h -4 z"/><path d="M 8,1 v 13 h 4 v -13 h -4 z"/></svg>');

Did you create this image? This is fine, but it should be possible to use two <rect> elements.

[Roger Fong]

(In reply to comment #3)
> Comment on attachment 247901 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=247901&action=review
> 
> > Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:134
> > +    background-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 12 15" fill="white"><path d="M 0,1 v 13 h 4 v -13 h -4 z"/><path d="M 8,1 v 13 h 4 v -13 h -4 z"/></svg>');
> 
> Did you create this image? This is fine, but it should be possible to use
> two <rect> elements.

I just followed what they were already doing in the previous pause svg code.
I can use rects too though.

[Roger Fong]

With rects:

http://trac.webkit.org/changeset/181046

[Alexey Proskuryakov]

This broke two tests: https://build.webkit.org/results/Apple%20Yosemite%20Release%20WK2%20(Tests)/r181049%20(3326)/results.html

I'm sure that EWS would have told so if you could wait for it.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 142318

[Roger Fong]

Recommitted after skipping the two test failures.
http://trac.webkit.org/changeset/181096