Bug 142304 - Only Heap should be in charge of deciding how to select a subspace for a type
Summary: Only Heap should be in charge of deciding how to select a subspace for a type
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 141174
  Show dependency treegraph
 
Reported: 2015-03-04 12:57 PST by Filip Pizlo
Modified: 2015-03-04 13:33 PST (History)
0 users

See Also:


Attachments
the patch (10.37 KB, patch)
2015-03-04 12:59 PST, Filip Pizlo
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-03-04 12:57:17 PST
Currently the DFG, FTL, and JSCellInlines have some code duplication to decide which subspace/allocator to use for which type.  While working on bug 141174, I realized that I'll need to repeat this pattern again, and so I decided to reduce the code duplication somewhat.
Comment 1 Filip Pizlo 2015-03-04 12:59:38 PST
Created attachment 247885 [details]
the patch
Comment 2 Mark Lam 2015-03-04 13:01:57 PST
Comment on attachment 247885 [details]
the patch

r=me
Comment 3 Filip Pizlo 2015-03-04 13:33:14 PST
Landed in http://trac.webkit.org/changeset/181019