WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
142303
[Mac] Set SystemUIFontSelect in DRT and WKTR
https://bugs.webkit.org/show_bug.cgi?id=142303
Summary
[Mac] Set SystemUIFontSelect in DRT and WKTR
Alexey Proskuryakov
Reported
2015-03-04 12:51:01 PST
Set SystemUIFontSelect in DRT and WKTR.
Attachments
proposed patch
(3.75 KB, patch)
2015-03-04 12:52 PST
,
Alexey Proskuryakov
mmaxfield
: review+
Details
Formatted Diff
Diff
with iOS build fix
(3.78 KB, patch)
2015-03-04 13:48 PST
,
Alexey Proskuryakov
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2015-03-04 12:52:33 PST
Created
attachment 247884
[details]
proposed patch
Myles C. Maxfield
Comment 2
2015-03-04 13:26:14 PST
Comment on
attachment 247884
[details]
proposed patch View in context:
https://bugs.webkit.org/attachment.cgi?id=247884&action=review
> Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:72 > + [NSFont initialize];
This isn't listed in public API docs. Perhaps we should surround with respondsToSelector?
Alexey Proskuryakov
Comment 3
2015-03-04 13:48:43 PST
Created
attachment 247892
[details]
with iOS build fix
> This isn't listed in public API docs. Perhaps we should surround with respondsToSelector?
I don't think so - it's a documented NSObject class method. And even if it wasn't, we would want tests to fail hard if it disappeared in the future. Waiting for EWS...
Alexey Proskuryakov
Comment 4
2015-03-04 16:05:59 PST
rdar://problem/19985132
WebKit Commit Bot
Comment 5
2015-03-04 16:52:08 PST
Comment on
attachment 247892
[details]
with iOS build fix Clearing flags on attachment: 247892 Committed
r181052
: <
http://trac.webkit.org/changeset/181052
>
WebKit Commit Bot
Comment 6
2015-03-04 16:52:12 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug