Bug 142303 - [Mac] Set SystemUIFontSelect in DRT and WKTR
Summary: [Mac] Set SystemUIFontSelect in DRT and WKTR
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-03-04 12:51 PST by Alexey Proskuryakov
Modified: 2015-03-04 16:52 PST (History)
3 users (show)

See Also:

Attachments
proposed patch (3.75 KB, patch)
2015-03-04 12:52 PST, Alexey Proskuryakov 		mmaxfield: review+
Details | Formatted Diff | Diff
with iOS build fix (3.78 KB, patch)
2015-03-04 13:48 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-03-04 12:51:01 PST 
Set SystemUIFontSelect in DRT and WKTR.
Comment 1 Alexey Proskuryakov 2015-03-04 12:52:33 PST 
Created attachment 247884 [details]
proposed patch
Comment 2 Myles C. Maxfield 2015-03-04 13:26:14 PST 
Comment on attachment 247884 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247884&action=review

> Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:72
> +    [NSFont initialize];

This isn't listed in public API docs. Perhaps we should surround with respondsToSelector?
Comment 3 Alexey Proskuryakov 2015-03-04 13:48:43 PST 
Created attachment 247892 [details]
with iOS build fix

> This isn't listed in public API docs. Perhaps we should surround with respondsToSelector?

I don't think so - it's a documented NSObject class method. And even if it wasn't, we would want tests to fail hard if it disappeared in the future.

Waiting for EWS...
Comment 4 Alexey Proskuryakov 2015-03-04 16:05:59 PST 
rdar://problem/19985132
Comment 5 WebKit Commit Bot 2015-03-04 16:52:08 PST 
Comment on attachment 247892 [details]
with iOS build fix

Clearing flags on attachment: 247892

Committed r181052: <http://trac.webkit.org/changeset/181052>
Comment 6 WebKit Commit Bot 2015-03-04 16:52:12 PST 
All reviewed patches have been landed.  Closing bug.