Bug 142299 - move content extensions tests
Summary: move content extensions tests
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
Depends on:
Reported: 2015-03-04 12:17 PST by Alex Christensen
Modified: 2015-03-04 14:11 PST (History)
2 users (show)

See Also:

Patch (22.28 KB, patch)
2015-03-04 12:19 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (23.26 KB, patch)
2015-03-04 12:25 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (853.37 KB, application/zip)
2015-03-04 13:50 PST, Build Bot
no flags Details
Patch (27.06 KB, patch)
2015-03-04 14:02 PST, Alex Christensen
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-03-04 12:17:34 PST
I'm not sure where the name usercontentfilters came from.  Let's move the tests to a subdirectory called contentextensions to match the WebCore directory name.
Comment 1 Alex Christensen 2015-03-04 12:19:25 PST
Created attachment 247879 [details]
Comment 2 Alex Christensen 2015-03-04 12:19:55 PST
Remind myself to remove the empty directory when landing.
Comment 3 Alex Christensen 2015-03-04 12:25:40 PST
Created attachment 247880 [details]
Comment 4 Alex Christensen 2015-03-04 13:23:27 PST
Comment on attachment 247880 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=247880&action=review

> Tools/WebKitTestRunner/mac/TestControllerMac.mm:113
>      WKRetainPtr<WKStringRef> contentFilterStringWK = adoptWK(WKStringCreateWithCFString((CFStringRef)contentFilterString));
>      WKRetainPtr<WKUserContentFilterRef> filter = adoptWK(WKUserContentFilterCreate(name.get(), contentFilterStringWK.get()));

Also change contentFilterStringWK to contentExtensionStringWK
Comment 5 Build Bot 2015-03-04 13:50:30 PST
Comment on attachment 247880 [details]

Attachment 247880 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5725994086301696

New failing tests:
Comment 6 Build Bot 2015-03-04 13:50:33 PST
Created attachment 247893 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 7 Alex Christensen 2015-03-04 14:02:57 PST
Created attachment 247895 [details]
Comment 8 Alex Christensen 2015-03-04 14:04:31 PST
Also moved platform/mac/http/tests/usercontentfilter/basic-filter-expected.txt to http/tests/contentextensions/basic-filter-expected.txt because all the other expectations were there and it is only enabled in platform/mac-wk2/TestExpectations
Comment 9 Tim Horton 2015-03-04 14:08:20 PST
Comment on attachment 247895 [details]

Comment 10 Alex Christensen 2015-03-04 14:11:34 PST
done https://trac.webkit.org/r181031