RESOLVED FIXED 142295
optimize content extension backend 
https://bugs.webkit.org/show_bug.cgi?id=142295
Summary optimize content extension backend
Alex Christensen
Reported 2015-03-04 11:03:46 PST
Some small optimizations go a long way. There's no need to add duplicate actions to the serialized list as long as order is preserved. We can't check the whole list to see if a duplicate action has been added, because that would break ignore-previous-rules, but we can check the previous action, which is where most of the duplicate actions will be. Also, ignore-previous-rules ignores the previous rules only in that extension, but block can return early without processing other extensions.
Attachments
Patch (2.98 KB, patch)
2015-03-04 11:13 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (3.14 KB, patch)
2015-03-04 19:15 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2015-03-04 11:13:36 PST
Created attachment 247872 [details] Patch
Benjamin Poulain
Comment 2 2015-03-04 17:50:25 PST
Comment on attachment 247872 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247872&action=review > Source/WebCore/contentextensions/ContentExtensionCompiler.cpp:58 > + if (ruleIndex && rule.action() == ruleList[ruleIndex - 1].action()) > + continue; I don't think that is right, actionLocations should point to actionLocations[ruleIndex - 1] instead of actions.size()
Alex Christensen
Comment 3 2015-03-04 19:15:18 PST
Created attachment 247920 [details] Patch
WebKit Commit Bot
Comment 4 2015-03-04 20:54:33 PST
Comment on attachment 247920 [details] Patch Clearing flags on attachment: 247920 Committed r181065: <http://trac.webkit.org/changeset/181065>
WebKit Commit Bot
Comment 5 2015-03-04 20:54:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.