WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
142294
Message UI process when contentSize changes
https://bugs.webkit.org/show_bug.cgi?id=142294
Summary
Message UI process when contentSize changes
Beth Dakin
Reported
2015-03-04 10:45:08 PST
We should message the UI process when contentSize changes. This will enable us to account for dynamic heights in our scrolling performance test.
rdar://problem/19963165
Attachments
Patch
(7.20 KB, patch)
2015-03-04 10:49 PST
,
Beth Dakin
kling
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Beth Dakin
Comment 1
2015-03-04 10:49:11 PST
Created
attachment 247869
[details]
Patch
Andreas Kling
Comment 2
2015-03-04 11:02:36 PST
Comment on
attachment 247869
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=247869&action=review
r=me
> Source/WebKit2/UIProcess/PageClient.h:-158 > -#if PLATFORM(EFL) > virtual void didChangeContentSize(const WebCore::IntSize&) = 0; > -#endif
Since you're unmasking a pure virtual here, you'll need to update the Gtk+ subclass of PageClient as well.
Beth Dakin
Comment 3
2015-03-04 13:46:31 PST
(In reply to
comment #2
)
> Comment on
attachment 247869
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=247869&action=review
> > r=me > > > Source/WebKit2/UIProcess/PageClient.h:-158 > > -#if PLATFORM(EFL) > > virtual void didChangeContentSize(const WebCore::IntSize&) = 0; > > -#endif > > Since you're unmasking a pure virtual here, you'll need to update the Gtk+ > subclass of PageClient as well.
Thanks Andreas! I fixed this.
http://trac.webkit.org/changeset/181023
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug