Bug 142294 - Message UI process when contentSize changes
Summary: Message UI process when contentSize changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-04 10:45 PST by Beth Dakin
Modified: 2015-03-04 13:46 PST (History)
4 users (show)

See Also:

Attachments
Patch (7.20 KB, patch)
2015-03-04 10:49 PST, Beth Dakin 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2015-03-04 10:45:08 PST 
We should message the UI process when contentSize changes. This will enable us to account for dynamic heights in our scrolling performance test.

rdar://problem/19963165
Comment 1 Beth Dakin 2015-03-04 10:49:11 PST 
Created attachment 247869 [details]
Patch
Comment 2 Andreas Kling 2015-03-04 11:02:36 PST 
Comment on attachment 247869 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247869&action=review

r=me

> Source/WebKit2/UIProcess/PageClient.h:-158
> -#if PLATFORM(EFL)
>      virtual void didChangeContentSize(const WebCore::IntSize&) = 0;
> -#endif

Since you're unmasking a pure virtual here, you'll need to update the Gtk+ subclass of PageClient as well.
Comment 3 Beth Dakin 2015-03-04 13:46:31 PST 
(In reply to comment #2)
> Comment on attachment 247869 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=247869&action=review
> 
> r=me
> 
> > Source/WebKit2/UIProcess/PageClient.h:-158
> > -#if PLATFORM(EFL)
> >      virtual void didChangeContentSize(const WebCore::IntSize&) = 0;
> > -#endif
> 
> Since you're unmasking a pure virtual here, you'll need to update the Gtk+
> subclass of PageClient as well.

Thanks Andreas! I fixed this.

http://trac.webkit.org/changeset/181023