Bug 142290 - Web Inspector: TimelineViews should be displayed in a ContentViewContainer
Summary: Web Inspector: TimelineViews should be displayed in a ContentViewContainer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brian Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-03-04 09:49 PST by Brian Burg
Modified: 2015-03-04 12:24 PST (History)
8 users (show)

See Also:

Attachments
Proposed Fix (36.23 KB, patch)
2015-03-04 10:58 PST, Brian Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2015-03-04 09:49:12 PST 
TimelineRecordingContentView duplicates a bunch of logic for managing sub-views. We can give it a real ContentViewContainer to manage switching out the TimelineViews.
Comment 1 Radar WebKit Bug Importer 2015-03-04 09:49:35 PST 
<rdar://problem/20039418>
Comment 2 Brian Burg 2015-03-04 10:58:41 PST 
Created attachment 247870 [details]
Proposed Fix
Comment 3 Timothy Hatcher 2015-03-04 11:32:16 PST 
Comment on attachment 247870 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=247870&action=review

Very nice.

> Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:165
> +        return (contentView instanceof WebInspector.TimelineView) ? contentView : null;

Nit: No need for ().
Comment 4 WebKit Commit Bot 2015-03-04 12:24:27 PST 
Comment on attachment 247870 [details]
Proposed Fix

Clearing flags on attachment: 247870

Committed r181011: <http://trac.webkit.org/changeset/181011>
Comment 5 WebKit Commit Bot 2015-03-04 12:24:32 PST 
All reviewed patches have been landed.  Closing bug.