RESOLVED FIXED 142290
Web Inspector: TimelineViews should be displayed in a ContentViewContainer 
https://bugs.webkit.org/show_bug.cgi?id=142290
Summary Web Inspector: TimelineViews should be displayed in a ContentViewContainer
Brian Burg
Reported 2015-03-04 09:49:12 PST
TimelineRecordingContentView duplicates a bunch of logic for managing sub-views. We can give it a real ContentViewContainer to manage switching out the TimelineViews.
Attachments
Proposed Fix (36.23 KB, patch)
2015-03-04 10:58 PST, Brian Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-03-04 09:49:35 PST
<rdar://problem/20039418>
Brian Burg
Comment 2 2015-03-04 10:58:41 PST
Created attachment 247870 [details] Proposed Fix
Timothy Hatcher
Comment 3 2015-03-04 11:32:16 PST
Comment on attachment 247870 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=247870&action=review Very nice. > Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:165 > + return (contentView instanceof WebInspector.TimelineView) ? contentView : null; Nit: No need for ().
WebKit Commit Bot
Comment 4 2015-03-04 12:24:27 PST
Comment on attachment 247870 [details] Proposed Fix Clearing flags on attachment: 247870 Committed r181011: <http://trac.webkit.org/changeset/181011>
WebKit Commit Bot
Comment 5 2015-03-04 12:24:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.