Bug 142279 – Factor platform I/O out from NetworkCacheStorage

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Antti Koivisto]

NetworkCacheStorage should be cross-platform and use WebKit types.

[Antti Koivisto]

Created attachment 247861 [details]
patch

[Antti Koivisto]

Created attachment 247863 [details]
patch

[WebKit Commit Bot]

Attachment 247863 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:77:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:77:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:95:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannel.h:43:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannel.h:44:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 5 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antti Koivisto]

Created attachment 247865 [details]
patch

[WebKit Commit Bot]

Attachment 247865 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:77:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:77:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:95:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannel.h:43:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannel.h:44:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 5 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Comment on attachment 247865 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247865&action=review

r=me % nits.

> Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:126
> +        body = NetworkCacheData(reinterpret_cast<const uint8_t*>(responseData->data()), responseData->size());

Doesn't this work?
body = { reinterpret_cast<const uint8_t*>(responseData->data()), responseData->size() };

> Source/WebKit2/NetworkProcess/cache/NetworkCacheData.h:43
> +template<typename T> class DispatchPtr {

Feels like this could be in its own file.

> Source/WebKit2/NetworkProcess/cache/NetworkCacheData.h:97
> +    NetworkCacheData() { }

NetworkCacheData() = default; ?

> Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannel.h:49
> +    NetworkCacheIOChannel(int fd);

nit: explicit

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm:211
> +    data = NetworkCacheData { headerData };

Do we need to explicitly specific NetworkCacheData ?

[Build Bot]

Comment on attachment 247865 [details]
patch

Attachment 247865 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6540931918462976

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 247868 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Antti Koivisto]

> nit: explicit
> 
> > Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm:211
> > +    data = NetworkCacheData { headerData };
> 
> Do we need to explicitly specific NetworkCacheData ?

explicit prevents it from working. 

I feel we should stop cargo-culling about explicit.

[Antti Koivisto]

> I feel we should stop cargo-culling about explicit.

"culting"

[Chris Dumez]

(In reply to comment #10)
> > I feel we should stop cargo-culling about explicit.
> 
> "culting"

I discussed this with Andreas, and we sort-of agreed that using explicit is nice if calling the constructor is either lossy or potentially expensive. Otherwise, I don't think explicit matters that much.

[Antti Koivisto]

Created attachment 247875 [details]
another

[WebKit Commit Bot]

Attachment 247875 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:77:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:77:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:96:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannel.h:43:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannel.h:44:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 5 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 247875 [details]
another

Clearing flags on attachment: 247875

Committed r181020: <http://trac.webkit.org/changeset/181020>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.