RESOLVED FIXED 142264
Update time elapsed/remaining displayed for inline media controls on OSX 
https://bugs.webkit.org/show_bug.cgi?id=142264
Summary Update time elapsed/remaining displayed for inline media controls on OSX
Roger Fong
Reported 2015-03-04 00:42:03 PST
Update the time displays based off of new display spec for mac osx. rdar://problem/19997487
Attachments
patch (2.91 KB, patch)
2015-03-04 00:47 PST, Roger Fong 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Roger Fong
Comment 1 2015-03-04 00:47:11 PST
Created attachment 247850 [details] patch
Dean Jackson
Comment 2 2015-03-04 11:12:52 PST
Comment on attachment 247850 [details] patch FWIW, I was looking at this for iOS and decided I needed four different classes: time < 10 mins (3 digits), time < 60 mins (4 digits), time < 10 hours (5 digits) and then 6 digits for everything else (assuming we'd rarely care about 100 hour videos)
Roger Fong
Comment 3 2015-03-04 12:35:03 PST
Based on the OSX specs it looks like we at minimum display 4 digits, even if the length is < 10 minutes. It does however, look like we display only 5 digits if the time is >= 1 hour, < 10 h, and 6 digits for > 10 hours I'll make another class.
Roger Fong
Comment 4 2015-03-04 13:17:50 PST
Landed with an extra class for ten-hour-long-time: http://trac.webkit.org/changeset/181015
Note You need to log in before you can comment on or make changes to this bug.