Bug 142261 - <attachment> should show the file size as detail text below the icon
Summary: <attachment> should show the file size as detail text below the icon
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-03 22:54 PST by Tim Horton
Modified: 2015-03-04 17:40 PST (History)
11 users (show)

See Also:

Attachments
Patch (40.11 KB, patch)
2015-03-03 22:55 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-mavericks (518.38 KB, application/zip)
2015-03-03 23:57 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (665.19 KB, application/zip)
2015-03-04 00:04 PST, Build Bot 		no flags Details
Patch (40.81 KB, patch)
2015-03-04 11:54 PST, Tim Horton 		dino: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-03-03 22:54:28 PST 
<attachment> should show the file size as detail text below the icon
Comment 1 Tim Horton 2015-03-03 22:55:45 PST 
Created attachment 247841 [details]
Patch
Comment 2 Build Bot 2015-03-03 23:57:32 PST 
Comment on attachment 247841 [details]
Patch

Attachment 247841 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5700911208857600

New failing tests:
fast/attachment/attachment-subtitle.html
Comment 3 Build Bot 2015-03-03 23:57:36 PST 
Created attachment 247848 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 4 Build Bot 2015-03-04 00:04:05 PST 
Comment on attachment 247841 [details]
Patch

Attachment 247841 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4926638127054848

New failing tests:
fast/attachment/attachment-subtitle.html
Comment 5 Build Bot 2015-03-04 00:04:10 PST 
Created attachment 247849 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 6 Tim Horton 2015-03-04 00:06:24 PST 
Need to land those results for Mavericks.
Comment 7 Tim Horton 2015-03-04 11:54:44 PST 
Created attachment 247877 [details]
Patch
Comment 8 Dean Jackson 2015-03-04 17:35:29 PST 
Comment on attachment 247877 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247877&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:2237
> +    // FIXME: What attribute should we use?
> +    String subtitleText = attachment.attachmentElement().fastGetAttribute(subtitleAttr);
> +

I don't understand the FIXME

> Source/WebCore/rendering/RenderThemeMac.mm:2261
> +    CGRect lineBounds = CTLineGetBoundsWithOptions(subtitleLine.get(), 0);
> +
> +    // Center the line relative to the icon.
> +    CGFloat xOffset = (attachmentIconBackgroundSize / 2) - (lineBounds.size.width / 2);
> +    CGFloat yOffset = 0;
> +
> +    if (!lines.isEmpty())
> +        yOffset = lines.last().backgroundRect.maxY();
> +    else
> +        yOffset = attachmentIconBackgroundSize + attachmentIconToTitleMargin;
> +
> +    LabelLine labelLine;
> +    subtitleTextRect = FloatRect(xOffset, yOffset, lineBounds.size.width, lineBounds.size.height);

Again, would be easier to do this in the shadow document :|
Comment 9 Tim Horton 2015-03-04 17:40:08 PST 
http://trac.webkit.org/changeset/181056