Bug 142260 - [Win] Windows port is missing custom renderer for attachments
Summary: [Win] Windows port is missing custom renderer for attachments
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 142214
Blocks:
  Show dependency tree / graph
 
Reported: 2015-03-03 21:34 PST by Brent Fulgham
Modified: 2015-03-04 13:28 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2015-03-03 21:34:03 PST 
The following layout test is failing on Windows.

fast/attachment/attachment-label-highlight.html

The failure looks like the following:

--- /home/buildbot/slave/win-release-tests/build/layout-test-results/fast/attachment/attachment-label-highlight-expected.txt
+++ /home/buildbot/slave/win-release-tests/build/layout-test-results/fast/attachment/attachment-label-highlight-actual.txt
@@ -1,14 +1,13 @@
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
-layer at (0,0) size 800x108
-  RenderBlock {HTML} at (0,0) size 800x108
-    RenderBody {BODY} at (8,8) size 784x92
-      RenderAttachment {ATTACHMENT} at (0,0) size 60x77
-      RenderAttachment {ATTACHMENT} at (60,0) size 90x92
-      RenderAttachment {ATTACHMENT} at (150,0) size 90x92
-      RenderAttachment {ATTACHMENT} at (240,0) size 96x92
-      RenderAttachment {ATTACHMENT} at (336,0) size 102x92
-      RenderAttachment {ATTACHMENT} at (438,0) size 106x92
+layer at (0,0) size 800x8
+  RenderBlock {HTML} at (0,0) size 800x8
+    RenderBody {BODY} at (8,8) size 784x0
+      RenderInline {ATTACHMENT} at (0,0) size 0x0
+      RenderInline {ATTACHMENT} at (0,0) size 0x0
+      RenderInline {ATTACHMENT} at (0,0) size 0x0
+      RenderInline {ATTACHMENT} at (0,0) size 0x0
+      RenderInline {ATTACHMENT} at (0,0) size 0x0
+      RenderInline {ATTACHMENT} at (0,0) size 0x0
       RenderText {#text} at (0,0) size 0x0
-selection start: position 0 of child 2 {ATTACHMENT} of body
-selection end:   position 1 of child 7 {ATTACHMENT} of body
+caret: position 0 of body
Comment 1 Brent Fulgham 2015-03-03 21:37:34 PST 
On Windows, the various {ATTACHMENT} elements are empty, and reporting as the wrong render type.
Comment 2 Brent Fulgham 2015-03-03 21:40:13 PST 
Based on Bug 142214, it looks like RenderThemeWin needs an implementation of this logic.
Comment 3 Tim Horton 2015-03-03 21:45:52 PST 
I landed non-Mac baselines in http://trac.webkit.org/changeset/180975; does Windows fall back on Mac still? Otherwise, why is it not using the platform independent baselines?

> Based on Bug 142214, it looks like RenderThemeWin needs an implementation of this logic.

I wouldn't worry much about that yet.
Comment 4 Brent Fulgham 2015-03-03 21:48:22 PST 
(In reply to comment #3)
> I landed non-Mac baselines in http://trac.webkit.org/changeset/180975; does
> Windows fall back on Mac still? Otherwise, why is it not using the platform
> independent baselines?

It does fall back to mac, but unfortunately the bots are not up to date with your patch. That will *probably* resolve this.
Comment 5 Tim Horton 2015-03-03 22:11:51 PST 
(In reply to comment #4)
> (In reply to comment #3)
> > I landed non-Mac baselines in http://trac.webkit.org/changeset/180975; does
> > Windows fall back on Mac still? Otherwise, why is it not using the platform
> > independent baselines?
> 
> It does fall back to mac, but unfortunately the bots are not up to date with
> your patch. That will *probably* resolve this.

Well, no, probably not, because Mac has results that are different than everyone else. So if Windows falls back there it will still fail.
Comment 6 Brent Fulgham 2015-03-04 13:28:01 PST 
This bug is the cause of 'fast/attachment/attachment-rendering.html' failing as well.