Bug 142259 - [Content Extensions] Split parsing and compiling of content extensions into their own files
Summary: [Content Extensions] Split parsing and compiling of content extensions into t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-03 21:28 PST by Sam Weinig
Modified: 2015-03-04 08:41 PST (History)
1 user (show)

See Also:

Attachments
Patch (72.24 KB, patch)
2015-03-03 21:43 PST, Sam Weinig 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2015-03-03 21:28:20 PST 
[Content Extensions] Split parsing and compiling of content extensions into their own files
Comment 1 Sam Weinig 2015-03-03 21:43:23 PST 
Created attachment 247838 [details]
Patch
Comment 2 WebKit Commit Bot 2015-03-03 21:46:32 PST 
Attachment 247838 [details] did not pass style-queue:


ERROR: Source/WebCore/contentextensions/ContentExtensionsBackend.cpp:40:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/contentextensions/ContentExtensionsBackend.h:55:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2015-03-04 08:38:37 PST 
Comment on attachment 247838 [details]
Patch

rs=me
Comment 4 Sam Weinig 2015-03-04 08:41:52 PST 
Committed r181000: <http://trac.webkit.org/changeset/181000>