WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
142259
[Content Extensions] Split parsing and compiling of content extensions into their own files
https://bugs.webkit.org/show_bug.cgi?id=142259
Summary
[Content Extensions] Split parsing and compiling of content extensions into t...
Sam Weinig
Reported
2015-03-03 21:28:20 PST
[Content Extensions] Split parsing and compiling of content extensions into their own files
Attachments
Patch
(72.24 KB, patch)
2015-03-03 21:43 PST
,
Sam Weinig
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2015-03-03 21:43:23 PST
Created
attachment 247838
[details]
Patch
WebKit Commit Bot
Comment 2
2015-03-03 21:46:32 PST
Attachment 247838
[details]
did not pass style-queue: ERROR: Source/WebCore/contentextensions/ContentExtensionsBackend.cpp:40: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] ERROR: Source/WebCore/contentextensions/ContentExtensionsBackend.h:55: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 2 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3
2015-03-04 08:38:37 PST
Comment on
attachment 247838
[details]
Patch rs=me
Sam Weinig
Comment 4
2015-03-04 08:41:52 PST
Committed
r181000
: <
http://trac.webkit.org/changeset/181000
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug