Bug 142255 - [Content Filtering] Make it easier to add new content filters
Summary: [Content Filtering] Make it easier to add new content filters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks: 128858
  Show dependency tree / graph
 
Reported: 2015-03-03 20:39 PST by Andy Estes
Modified: 2015-03-04 14:43 PST (History)
2 users (show)

See Also:

Attachments
Patch (40.33 KB, patch)
2015-03-03 21:55 PST, Andy Estes 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2015-03-03 20:39:10 PST 
[Content Filtering] Make it easier to add new content filters
Comment 1 Andy Estes 2015-03-03 21:55:47 PST 
Created attachment 247839 [details]
Patch
Comment 2 WebKit Commit Bot 2015-03-03 21:57:36 PST 
Attachment 247839 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/cocoa/ParentalControlsContentFilter.mm:60:  Missing spaces around :  [whitespace/init] [4]
ERROR: Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm:53:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm:79:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm:94:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 4 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andy Estes 2015-03-04 14:43:59 PST 
Committed r181037: <http://trac.webkit.org/changeset/181037>