Bug 142252 - Remove WK_AVAILABLE and related macros when we cannot determine iOS/Mac version
Summary: Remove WK_AVAILABLE and related macros when we cannot determine iOS/Mac version
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-03 18:11 PST by Joseph Pecoraro
Modified: 2015-03-04 10:49 PST (History)
3 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (3.22 KB, patch)
2015-03-03 18:15 PST, Joseph Pecoraro 		ddkilzer: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-03-03 18:11:23 PST 
* SUMMARY
Better build fix when PLATFORM_NAME is unknown/missing. In such cases, we cannot determine the iOS/Mac version numbers, so just remove WK_AVAILABLE / WK_DEPRECATED macros that may contain WK_MAC_TBA/WK_IOS_TBA in the postprocess build step so we don't output a broken NS macro.
Comment 1 Joseph Pecoraro 2015-03-03 18:15:06 PST 
Created attachment 247823 [details]
[PATCH] Proposed Fix
Comment 2 David Kilzer (:ddkilzer) 2015-03-04 09:43:55 PST 
Comment on attachment 247823 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=247823&action=review

r=me

> Source/WebKit2/mac/postprocess-framework-headers.sh:50
> +            if [[ -n $OSX_VERSION ]] && [[ -n $IOS_VERSION ]]; then

Should the variables be double-quoted in case they're not set?

            if [[ -n "$OSX_VERSION" ]] && [[ -n "$IOS_VERSION" ]]; then
Comment 3 Joseph Pecoraro 2015-03-04 10:49:38 PST 
http://trac.webkit.org/changeset/181004