RESOLVED FIXED142251
[Content Filtering] Separate unblock handling into its own class 
https://bugs.webkit.org/show_bug.cgi?id=142251
Summary [Content Filtering] Separate unblock handling into its own class
Andy Estes
Reported 2015-03-03 17:58:59 PST
[Content Filtering] Separate unblock handling into its own class
Attachments
Patch (42.81 KB, patch)
2015-03-03 18:23 PST, Andy Estes 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2015-03-03 18:23:12 PST
Created attachment 247825 [details] Patch
WebKit Commit Bot
Comment 2 2015-03-03 18:25:31 PST
Attachment 247825 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ContentFilterUnblockHandler.h:45: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:55: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:80: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 4 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2015-03-03 19:24:09 PST
Comment on attachment 247825 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247825&action=review r=me > Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:66 > + static const char contentFilterScheme[] = "x-apple-content-filter"; > + return contentFilterScheme; return "x-apple-content-filter";
Andy Estes
Comment 4 2015-03-03 19:36:33 PST
Committed r180985: <http://trac.webkit.org/changeset/180985>
Note You need to log in before you can comment on or make changes to this bug.