Bug 142251 - [Content Filtering] Separate unblock handling into its own class
Summary: [Content Filtering] Separate unblock handling into its own class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks: 128858
  Show dependency tree / graph
 
Reported: 2015-03-03 17:58 PST by Andy Estes
Modified: 2015-03-03 19:36 PST (History)
2 users (show)

See Also:

Attachments
Patch (42.81 KB, patch)
2015-03-03 18:23 PST, Andy Estes 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2015-03-03 17:58:59 PST 
[Content Filtering] Separate unblock handling into its own class
Comment 1 Andy Estes 2015-03-03 18:23:12 PST 
Created attachment 247825 [details]
Patch
Comment 2 WebKit Commit Bot 2015-03-03 18:25:31 PST 
Attachment 247825 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ContentFilterUnblockHandler.h:45:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:55:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:55:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:80:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 4 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2015-03-03 19:24:09 PST 
Comment on attachment 247825 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247825&action=review

r=me

> Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:66
> +    static const char contentFilterScheme[] = "x-apple-content-filter";
> +    return contentFilterScheme;

return "x-apple-content-filter";
Comment 4 Andy Estes 2015-03-03 19:36:33 PST 
Committed r180985: <http://trac.webkit.org/changeset/180985>