Bug 142231 - bmalloc: Miscellaneous cleanup
Summary: bmalloc: Miscellaneous cleanup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-03 12:22 PST by Geoffrey Garen
Modified: 2015-03-03 13:48 PST (History)
1 user (show)

See Also:

Attachments
Patch (10.04 KB, patch)
2015-03-03 12:28 PST, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (10.06 KB, patch)
2015-03-03 12:34 PST, Geoffrey Garen 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2015-03-03 12:22:08 PST 
bmalloc: Miscellaneous cleanup
Comment 1 Geoffrey Garen 2015-03-03 12:28:04 PST 
Created attachment 247778 [details]
Patch
Comment 2 Geoffrey Garen 2015-03-03 12:34:34 PST 
Created attachment 247780 [details]
Patch
Comment 3 Andreas Kling 2015-03-03 13:13:36 PST 
Comment on attachment 247780 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247780&action=review

r=me

> Source/bmalloc/bmalloc/Vector.h:92
> -    vmDeallocate(m_buffer, vmSize(m_capacity * sizeof(T)));
> +    if (m_buffer)
> +        vmDeallocate(m_buffer, vmSize(m_capacity * sizeof(T)));

Whoops :o
Comment 4 Geoffrey Garen 2015-03-03 13:48:10 PST 
Committed r180953: <http://trac.webkit.org/changeset/180953>