Bug 142182 - Baseline JIT op_new_func_exp shouldn't check for undefined scope
Summary: Baseline JIT op_new_func_exp shouldn't check for undefined scope
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 141174
  Show dependency treegraph
 
Reported: 2015-03-02 11:20 PST by Filip Pizlo
Modified: 2015-03-02 14:39 PST (History)
3 users (show)

See Also:


Attachments
the patch (2.03 KB, patch)
2015-03-02 11:21 PST, Filip Pizlo
msaboff: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-mavericks (594.05 KB, application/zip)
2015-03-02 11:40 PST, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-03-02 11:20:04 PST
We don't do undefined scopes anymore.
Comment 1 Filip Pizlo 2015-03-02 11:21:45 PST
Created attachment 247683 [details]
the patch
Comment 2 Michael Saboff 2015-03-02 11:23:52 PST
Comment on attachment 247683 [details]
the patch

r=me
Comment 3 Build Bot 2015-03-02 11:40:38 PST
Comment on attachment 247683 [details]
the patch

Attachment 247683 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5414865313202176

New failing tests:
js/regress-140033.html
Comment 4 Build Bot 2015-03-02 11:40:41 PST
Created attachment 247686 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 5 Filip Pizlo 2015-03-02 11:41:55 PST
Oh, this is actually still needed due to OSR exit.
Comment 6 Geoffrey Garen 2015-03-02 12:49:42 PST
This requirement of OSR exit is pretty surprising. :(
Comment 7 Filip Pizlo 2015-03-02 14:39:08 PST
(In reply to comment #6)
> This requirement of OSR exit is pretty surprising. :(

I like that the baseline JIT is sort of enslaved to the whims of OSR exit; this tends to be easier to reason about than exit-time rematerialization.  We should do a better job of documenting this contract, though.